You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/04 12:42:18 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30247: [SPARK-33341][CORE][SQL][MESOS]Remove unnecessary semicolons in Scala code

HyukjinKwon commented on a change in pull request #30247:
URL: https://github.com/apache/spark/pull/30247#discussion_r517315456



##########
File path: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala
##########
@@ -59,7 +59,7 @@ class HistoryServer(
   private val retainedApplications = conf.get(History.RETAINED_APPLICATIONS)
 
   // How many applications the summary ui displays
-  private[history] val maxApplications = conf.get(HISTORY_UI_MAX_APPS);
+  private[history] val maxApplications = conf.get(HISTORY_UI_MAX_APPS)

Review comment:
       Does this show any warnings? If not, let's don't do this. It will make difficult to maintain e.g.) backporting or revert but the gain is just cosmetic stuffs 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org