You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/10/29 12:03:00 UTC

[kudu-CR] KUDU-1929 p1: trash is supported while dropping tables 

helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14566


Change subject: KUDU-1929 p1: trash is supported while dropping tables
......................................................................

KUDU-1929 p1: trash is supported while dropping tables

1) Add a new field to persist the deletion time for the trashed
table/tablets on the master;
2) Add a new boolean variable to represent the trash state for
tablets on the tserver;
3) The trash state of the tablet can be synchronized by heartbeat
messages (master -> tserver);
4) The CatalogManagerBgTasks will delete the trash tables that
are timeout.

Change-Id: I112da81727db6f64026a54311d88e436c34ad6d8
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/master/master_service.h
M src/kudu/tablet/metadata.proto
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/tserver/tserver_admin.proto
19 files changed, 2,164 insertions(+), 1,297 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/14566/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I112da81727db6f64026a54311d88e436c34ad6d8
Gerrit-Change-Number: 14566
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>

[kudu-CR] KUDU-2919 p1: trash is supported while dropping tables

Posted by "helifu (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14566

to look at the new patch set (#4).

Change subject: KUDU-2919 p1: trash is supported while dropping tables
......................................................................

KUDU-2919 p1: trash is supported while dropping tables

1) Add a new field to persist the deletion time for the trashed
table/tablets on the master;
2) Add a new boolean variable to represent the trash state for
tablets on the tserver;
3) The trash state of the tablet can be synchronized by heartbeat
messages (master -> tserver), even if the tserver restarts;
4) The CatalogManagerBgTasks will delete the trash tables that
are timeout;
5) Add a new RollbackTable API to roll back the trashed table.

Change-Id: I112da81727db6f64026a54311d88e436c34ad6d8
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/master/master_service.h
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/tserver/tserver_admin.proto
18 files changed, 915 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/14566/4
-- 
To view, visit http://gerrit.cloudera.org:8080/14566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I112da81727db6f64026a54311d88e436c34ad6d8
Gerrit-Change-Number: 14566
Gerrit-PatchSet: 4
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>

[kudu-CR] KUDU-1929 p1: trash is supported while dropping tables

Posted by "helifu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14566

to look at the new patch set (#2).

Change subject: KUDU-1929 p1: trash is supported while dropping tables
......................................................................

KUDU-1929 p1: trash is supported while dropping tables

1) Add a new field to persist the deletion time for the trashed
table/tablets on the master;
2) Add a new boolean variable to represent the trash state for
tablets on the tserver;
3) The trash state of the tablet can be synchronized by heartbeat
messages (master -> tserver);
4) The CatalogManagerBgTasks will delete the trash tables that
are timeout.

Change-Id: I112da81727db6f64026a54311d88e436c34ad6d8
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/master/master_service.h
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/tserver/tserver_admin.proto
18 files changed, 915 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/14566/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I112da81727db6f64026a54311d88e436c34ad6d8
Gerrit-Change-Number: 14566
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1929 p1: trash is supported while dropping tables

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14566 )

Change subject: KUDU-1929 p1: trash is supported while dropping tables
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14566/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14566/3//COMMIT_MSG@7
PS3, Line 7: KUDU-1929 p1: trash is supported while dropping tables
it should be KUDU-2919



-- 
To view, visit http://gerrit.cloudera.org:8080/14566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I112da81727db6f64026a54311d88e436c34ad6d8
Gerrit-Change-Number: 14566
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Nov 2019 19:48:57 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1929 p1: trash is supported while dropping tables

Posted by "helifu (Code Review)" <ge...@cloudera.org>.
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14566 )

Change subject: KUDU-1929 p1: trash is supported while dropping tables
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14566/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14566/3//COMMIT_MSG@7
PS3, Line 7: KUDU-1929 p1: trash is supported while dropping tables
> it should be KUDU-2919
Thank you for pointing out the mistake, Attila^_^



-- 
To view, visit http://gerrit.cloudera.org:8080/14566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I112da81727db6f64026a54311d88e436c34ad6d8
Gerrit-Change-Number: 14566
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 00:46:20 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1929 p1: trash is supported while dropping tables

Posted by "helifu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14566

to look at the new patch set (#3).

Change subject: KUDU-1929 p1: trash is supported while dropping tables
......................................................................

KUDU-1929 p1: trash is supported while dropping tables

1) Add a new field to persist the deletion time for the trashed
table/tablets on the master;
2) Add a new boolean variable to represent the trash state for
tablets on the tserver;
3) The trash state of the tablet can be synchronized by heartbeat
messages (master -> tserver), even if the tserver restarts;
4) The CatalogManagerBgTasks will delete the trash tables that
are timeout;
5) Add a new RollbackTable API to roll back the trashed table.

Change-Id: I112da81727db6f64026a54311d88e436c34ad6d8
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/master_proxy_rpc.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/master/master_service.h
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/tserver/tserver_admin.proto
18 files changed, 915 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/14566/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14566
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I112da81727db6f64026a54311d88e436c34ad6d8
Gerrit-Change-Number: 14566
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Kudu Jenkins (120)