Re: config.xml changes

[Joe Bohn <jo...@earthlink.net>]

Thanks for the explanation David.  I'll look into the 
geronimo-plugins.xml for Tomcat.  I'll also try adding some comments in 
the geronimo-plugins.xml and see if it makes it into the config.xml.

Joe


David Jencks wrote:
> 
> On Oct 31, 2007, at 2:02 PM, Joe Bohn wrote:
> 
>> I'm having a difficult time understanding the changes to config.xml. 
>> Can somebody help me out?  How do things work now, where are they 
>> headed, and can include optional items for users still via comments?
>> I apologize if I missed a dev post about the changes already.
>>
>>
>> I was used to config.xml in the source for each assembly that included 
>> things like:
>> - it was formatted to be easily read
>> - it included items which were commented out to help users making 
>> common changes.
>> - I know it didn't include a complete list of the all the gbeans but 
>> it had most of them that a user might need to touch.
>>
>>
>> Now:
>> - config.xml it no longer exists in src for each assembly.  I assume 
>> it is generated via the build.  Does it use info in the pom for the 
>> assembly to create the target config.xml?
> 
> It's assembled from the snippets in the geronimo-plugins.xml
>> - it is not formatted so it's a bit more difficult to read.
> We probably need to use jaxb to read-write it to solve this one.  I'll 
> look into this.
>> - it does not include comments or tips for the user on how to 
>> enable/disable function - it would be nice if we could get some of 
>> that get that back.
> Maybe we need to put the comments into the geronimo-plugins.xml for each 
> plugin?
>> - Finally, I don't see all the same content in there that we had 
>> before.  For example, I was looking for TomcatEngine gbean but I don't 
>> see that in the config.xml for the tomcat-javaee5 server in trunk.  On 
>> the other hand, I see a GBean def for TomcatWebContainer that wasn't 
>> in the 2.0.2 config.xml.
> I thought I constructed the geronimo-plugins.xml content by copying the 
> appropriate stuff from the old config.xml.  I might have missed 
> something.  In any case by editing the plugins' pom (the source of this 
> config) you can get the gbeans you want into config.xml.
> 
> thanks
> david jencks
>>
>> Joe
> 
> 

Re: config.xml changes

[Joe Bohn <jo...@earthlink.net>]

David Jencks wrote:
> 
> On Nov 1, 2007, at 9:11 AM, Joe Bohn wrote:
> 
>>
>>
>> Joe Bohn wrote:
>>> Thanks for the explanation David.  I'll look into the 
>>> geronimo-plugins.xml for Tomcat.  I'll also try adding some comments 
>>> in the geronimo-plugins.xml and see if it makes it into the config.xml.
>>
>> Well, I guess adding comments into geronimo-plugin.xml isn't going to 
>> work since those files themselves are generated too.  I think this all 
>> goes back to the poms, right?
> 
> Yes, but I would think we could add comment elements there -- didn't 
> someone recently add this less-volatile way of commenting?  BTW I expect 
> to be reworking the LocalAttributeManager to use jaxb shortly.

I'll keep on experimenting.  Comments added in the pom 
<config-xml-content> don't make it into the geronimo-plugin.xml or the 
config.xml.

I'm not sure what the less-volatile way of commenting is but I'll keep 
looking.  I did see some enhancements to preserve comments that were 
added by users to config.xml.

BTW, the TomcatEngine gbean didn't appear in the config.xml because it 
was already "commented out" in the pom with info on how to remove access 
logging (which is why I started looking into this in the first place :-) ).

Joe

Re: config.xml changes

["Jay D. McHugh" <ja...@jnwd.net>]

David Jencks wrote:
>
> On Nov 1, 2007, at 9:11 AM, Joe Bohn wrote:
>
>>
>>
>> Joe Bohn wrote:
>>> Thanks for the explanation David.  I'll look into the 
>>> geronimo-plugins.xml for Tomcat.  I'll also try adding some comments 
>>> in the geronimo-plugins.xml and see if it makes it into the config.xml.
>>
>> Well, I guess adding comments into geronimo-plugin.xml isn't going to 
>> work since those files themselves are generated too.  I think this 
>> all goes back to the poms, right?
>
> Yes, but I would think we could add comment elements there -- didn't 
> someone recently add this less-volatile way of commenting?  BTW I 
> expect to be reworking the LocalAttributeManager to use jaxb shortly.
>
> thanks
> david jencks
>>
>> Joe
>>
>
>
>
There has been a change added that allows comments to be maintained in 
the config.xml file through server start/stops and config changes.  It 
requires the use of the attributes-1.2 schema (which seems to be the 
currently used version in the geronimo-plugins.xml files).  So, it 
shouldn't be too painful to add support for comments in the 
geronimo-plugins.xml.

Where are these files being generated from the poms?

Jay

Re: config.xml changes

[David Jencks <da...@yahoo.com>]

On Nov 1, 2007, at 9:11 AM, Joe Bohn wrote:

>
>
> Joe Bohn wrote:
>> Thanks for the explanation David.  I'll look into the geronimo- 
>> plugins.xml for Tomcat.  I'll also try adding some comments in the  
>> geronimo-plugins.xml and see if it makes it into the config.xml.
>
> Well, I guess adding comments into geronimo-plugin.xml isn't going  
> to work since those files themselves are generated too.  I think  
> this all goes back to the poms, right?

Yes, but I would think we could add comment elements there -- didn't  
someone recently add this less-volatile way of commenting?  BTW I  
expect to be reworking the LocalAttributeManager to use jaxb shortly.

thanks
david jencks
>
> Joe
>

Re: config.xml changes

[Joe Bohn <jo...@earthlink.net>]

Joe Bohn wrote:
> Thanks for the explanation David.  I'll look into the 
> geronimo-plugins.xml for Tomcat.  I'll also try adding some comments in 
> the geronimo-plugins.xml and see if it makes it into the config.xml.

Well, I guess adding comments into geronimo-plugin.xml isn't going to 
work since those files themselves are generated too.  I think this all 
goes back to the poms, right?

Joe