You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Marcel Thannhäuser (JIRA)" <ji...@apache.org> on 2017/03/22 13:04:41 UTC
[jira] [Closed] (HTTPCLIENT-1832) Provide InputStreamBody with
contentLength if known
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Thannhäuser closed HTTPCLIENT-1832.
------------------------------------------
Review looks good. Great!
> Provide InputStreamBody with contentLength if known
> ---------------------------------------------------
>
> Key: HTTPCLIENT-1832
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1832
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient (classic)
> Affects Versions: 4.5.3
> Environment: windows 10 64 bit, oracle jdk 1.8.0_112 64bit
> Reporter: Marcel Thannhäuser
> Fix For: 4.6 Alpha1, 5.0 Alpha2
>
>
> When building a multipart request that consists of at least one body where the contentLength is -1 in AbstractMultipartForm#getTotalLength -1 is returned, resulting in a missing Content-Length header in the request. This behaviour is correct.
> But in some cases you know the contentLength of a body part even though it might be streamed.
> To implement this I subclassed org.apache.http.entity.mime.content.InputStreamBody
> public class ContentLengthInputStreamBody extends InputStreamBody {
> private final long contentLength;
>
> public ContentLengthInputStreamBody(InputStream in, ContentType contentType, String filename, long contentLength ) {
> super(in, contentType, filename);
> this.contentLength = contentLength;
> }
> @Override
> public long getContentLength() {
> return this.contentLength;
> }
>
> }
> I also needed to do this because a foreign HTTP Server, which is not under my control, refused to handle my request when the Content-Length header was not set.
> This might not be a common issue nor is it hard to solve, but you might think of adding this functionality to InputStreamBody itself.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org