You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2015/10/19 11:33:30 UTC

[Bug 7255] New: `dmake install` fails on windows

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7255

            Bug ID: 7255
           Summary: `dmake install` fails on windows
           Product: Spamassassin
           Version: 3.4 SVN branch
          Hardware: PC
                OS: Windows 7
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Building & Packaging
          Assignee: dev@spamassassin.apache.org
          Reporter: puppe@jam-software.com

Created attachment 5338
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5338&action=edit
dmake-compatible Makefile

Strawberry Perl comes with dmake, and MakeMaker emits dmake-style Makefiles.
`dmake install` fails with the following message:

```
"D:\Strawberry\perl\bin\perl.exe" -MFile::Copy -e "copy(qrules/local.cf,
qD:\Str
awberry\perl\site/etc/mail/spamassassin/local.cf) unless -f
qD:\Strawberry\perl\
site/etc/mail/spamassassin/local.cf"
Backslash found where operator expected at -e line 1, near "Strawberry\"
Backslash found where operator expected at -e line 1, near "perl\"
Backslash found where operator expected at -e line 1, near "Strawberry\"
Backslash found where operator expected at -e line 1, near "perl\"
syntax error at -e line 1, near "local."
Execution of -e aborted due to compilation errors.
dmake:  Error code 255, while making 'conf__install'
```

The problem is that braces have significance for dmake. They need to be escaped
by doubling. Replacing them with brackets instead is probably more portable.
See attached patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7255] `dmake install` fails on windows

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7255

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com

--- Comment #1 from Kevin A. McGrail <km...@pccc.com> ---
I checked this on my linux system and it appears to work fine.  The key change
is some { to {.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7255] `dmake install` fails on windows

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7255

--- Comment #2 from Kevin A. McGrail <km...@pccc.com> ---
that is { to [

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7255] `dmake install` fails on windows

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7255

Martin Puppe <pu...@jam-software.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #5 from Martin Puppe <pu...@jam-software.com> ---
Reopening the bug (see above for the reason).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7255] `dmake install` fails on windows

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7255

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #6 from Kevin A. McGrail <km...@apache.org> ---
Thanks Martin, now that 3.4.2 is out, I've added this to 3.4 and trunk

3.4:
Committed revision 1841063.
trunk:
Committed revision 1841064.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7255] `dmake install` fails on windows

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7255

Joe Quinn <jq...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jquinn+SAbug@pccc.com
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Joe Quinn <jq...@pccc.com> ---
Looks good when I test it as well. Committed to 4.0 and 3.4.2

Committed revision 1710600.
Committed revision 1710602.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7255] `dmake install` fails on windows

Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7255

Martin Puppe <pu...@jam-software.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5338|0                           |1
        is obsolete|                            |
                 CC|                            |puppe@jam-software.com

--- Comment #4 from Martin Puppe <pu...@jam-software.com> ---
Created attachment 5596
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5596&action=edit
Updated patch

The previous patch has only been partially applied. Here is a new patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.