You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/11 18:47:07 UTC
[GitHub] [netbeans] BradWalker opened a new pull request #2756: [NETBEANS-5354] - update public interface for a few users of LinkedList
BradWalker opened a new pull request #2756:
URL: https://github.com/apache/netbeans/pull/2756
I've wanted to expand my knowledge about how to change the interface. So I've picked a simple one to change..
I've changed the interface to use List instead of LinkedList. One should use interfaces and not implementations in the public interface.. Changing this will allow me to fix the following warnings easily.
[repeat] /home/bwalker/src/netbeans/enterprise/websvc.manager/src/org/netbeans/modules/websvc/manager/ui/TestWebServiceMethodDlg.java:390: warning: [rawtypes] found raw type: LinkedList
[repeat] public void methodFinished(final Object inReturnedObject,final LinkedList inParamList) {
[repeat] ^
[repeat] missing type arguments for generic class LinkedList<E>
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class LinkedList
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2756: [NETBEANS-5354] - update public interface for a few users of LinkedList
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2756:
URL: https://github.com/apache/netbeans/pull/2756#discussion_r577672208
##########
File path: enterprise/websvc.manager/manifest.mf
##########
@@ -3,5 +3,5 @@ AutoUpdate-Show-In-Client: false
OpenIDE-Module: org.netbeans.modules.websvc.manager
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/websvc/manager/Bundle.properties
OpenIDE-Module-Install: org/netbeans/modules/websvc/manager/WebServiceModuleInstaller.class
-OpenIDE-Module-Specification-Version: 1.39
+OpenIDE-Module-Specification-Version: 1.40
Review comment:
Is this a functional change - new or altered behaviour ? All changed classes are in impl package not exposed outside the module: no spec version change is needed IMHO.
##########
File path: java/dbschema/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.dbschema/1
-OpenIDE-Module-Implementation-Version: 4
+OpenIDE-Module-Implementation-Version: 5
Review comment:
Here you probably want to increment `specification-version` (see `project.properties`). You're changing `friend-public` API in a binary-incompatible way (but that should not matter as all friends are recompiled in the tree - right @JaroslavTulach ?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker closed pull request #2756: [NETBEANS-5354] - update public interface for a few users of LinkedList
Posted by GitBox <gi...@apache.org>.
BradWalker closed pull request #2756:
URL: https://github.com/apache/netbeans/pull/2756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2756: [NETBEANS-5354] - update public interface for a few users of LinkedList
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2756:
URL: https://github.com/apache/netbeans/pull/2756#discussion_r578993565
##########
File path: java/dbschema/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.dbschema/1
-OpenIDE-Module-Implementation-Version: 4
+OpenIDE-Module-Implementation-Version: 5
Review comment:
Thanks for CCing me, Sváťo!
I see that the [signature test](https://travis-ci.com/github/apache/netbeans/jobs/482358349) failed with:
```
Class org.netbeans.modules.dbschema.jdbcimpl.IndexElementImpl
"E1.2 - API type removed" : method protected void org.netbeans.modules.dbschema.jdbcimpl.IndexElementImpl.initColumns(java.util.LinkedList)
Class org.netbeans.modules.dbschema.jdbcimpl.SchemaElementImpl
"E1.2 - API type removed" : method public void org.netbeans.modules.dbschema.jdbcimpl.SchemaElementImpl.initTables(org.netbeans.modules.dbschema.jdbcimpl.ConnectionProvider,java.util.LinkedList,java.util.LinkedList)
```
I suggest to not change any public signature incompatibly. While...
> changing friend-public API in a binary-incompatible way (but that should not matter as all friends are recompiled in the tree
...is possible. You'd have to increase dependencies of all friend modules. It is easier to keep `LinkedList` where it was. Even I agree with [code against interfaces not implementation](http://wiki.apidesign.org/wiki/Code_Against_Interfaces%2C_Not_Implementations) advice, I value backward compatibility more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists