You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/04/24 20:56:09 UTC
[jira] [Commented] (HDFS-11972) CBlocks use wrong OPT env vars
[ https://issues.apache.org/jira/browse/HDFS-11972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451008#comment-16451008 ]
Hudson commented on HDFS-11972:
-------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14057/])
HDFS-11972. CBlocks use wrong OPT env vars. Contributed by Mukul Kumar (aengineer: rev ee4f021fbce3cb639eef38b4c88f0622ebee6234)
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* (edit) hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
> CBlocks use wrong OPT env vars
> ------------------------------
>
> Key: HDFS-11972
> URL: https://issues.apache.org/jira/browse/HDFS-11972
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Allen Wittenauer
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: HDFS-7240
>
> Attachments: HDFS-11972-HDFS-7240.001.patch
>
>
> Current codebase does:
> {code}
> hadoop_debug "Appending HADOOP_CBLOCK_OPTS onto HADOOP_OPTS"
> HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_CBLOCK_OPTS}"
> ...
> hadoop_debug "Appending HADOOP_JSCSI_OPTS onto HADOOP_OPTS"
> HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_JSCSI_OPTS}"
> {code}
> This code block breaks the consistency with the rest of the shell scripts:
> a) It should be HDFS_CBLOCKSERVER_OPTS, HDFS_JSCSI_OPTS
> b) _OPTS, unless they are a deprecated form or some other special case, are already/automatically appended; there is no need to do them specifically
> Also, a description of these env vars should be hadoop-env.sh for documentation purposes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org