You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2008/04/22 18:07:04 UTC

svn commit: r650563 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: remm
Date: Tue Apr 22 09:07:02 2008
New Revision: 650563

URL: http://svn.apache.org/viewvc?rev=650563&view=rev
Log:
- Votes.

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=650563&r1=650562&r2=650563&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Apr 22 09:07:02 2008
@@ -80,34 +80,55 @@
   Need to identify new wrapper for queued request after reload
   http://svn.apache.org/viewvc?rev=649302&view=rev
   +1: markt
+  -1: remm (there's a check for null on the next line -> not good; other than that small glitch,
+      this is not an expensive check unless it is unavailable so it's probably fine; honestly,
+      I would still consider adding isStarted to Container - maybe it should be in Lifecycle, 
+      but I'd say any container should have the flag)
+      
+        // Select the Wrapper to be used for this Request
+        Wrapper wrapper = request.getWrapper();
+        if (wrapper == null) {
+            String requestURI = request.getDecodedRequestURI();
+            notFound(requestURI, response);
+            return;
+        } else if (wrapper.isUnavailable()) {
+         // May be as a result of a reload, try and find the new wrapper
+            wrapper = (Wrapper) container.findChild(wrapper.getName());
+            if (wrapper == null) {
+                String requestURI = request.getDecodedRequestURI();
+                notFound(requestURI, response);
+                return;
+            }
+        }
+      
   -1:
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43656
   coerceToType() modifies some values. Patch provided by Nils Eckert
   http://svn.apache.org/viewvc?rev=649638&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Add test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=43656
   http://svn.apache.org/viewvc?rev=649783&view=rev
   http://svn.apache.org/viewvc?rev=649785&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fixes to make test case above pass
   http://svn.apache.org/viewvc?rev=649784&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=29936
   Create digesters and parsers earlier so we aren't using the webapp class
   loader when we create them.
   http://svn.apache.org/viewvc?rev=649974&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=31257
   Quote endorsed dirs if they contain a space
   http://svn.apache.org/viewvc?rev=649993&view=rev
-  +1: markt
+  +1: markt, remm
   -1: 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org