[jira] [Commented] (HBASE-4955) Use the official versions of surefire & junit

["nkeywal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510559#comment-13510559 ] 

nkeywal commented on HBASE-4955:
--------------------------------

Retested 3 times again on trunk, these errors are always there. I don't always have then when I test with the current JUnit:
 testZNodeDeletes(org.apache.hadoop.hbase.TestZooKeeper): KeeperErrorCode = NoAuth for /l1
 testFlushCommitsWithAbort(org.apache.hadoop.hbase.client.TestMultiParallel): Server count=2, abort=true expected:<1> but was:<2>

JUnit 4.11 is out for a month, no one raised an issue about it. So may be we have flaky tests that are now just failed tests on 4.11 (i.e. a bug on out side that always appears with 4.11?). We can either wait a little bit more, for example waiting for more validation work on 0.96, either push it now, expecting someone will be motivated about finding the root issue, either try to fix the issue before pushing :-).
                
> Use the official versions of surefire & junit
> ---------------------------------------------
>
>                 Key: HBASE-4955
>                 URL: https://issues.apache.org/jira/browse/HBASE-4955
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.94.0
>         Environment: all
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the trunk
> 786 (@Category with forkMode=always): fixed, we use the official implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk, not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk, fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are fixed in our version but not on trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira