You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2011/07/07 15:32:20 UTC
[jira] [Created] (BOOKKEEPER-32) Clean up LOG.debug statements
Clean up LOG.debug statements
-----------------------------
Key: BOOKKEEPER-32
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-32
Project: Bookkeeper
Issue Type: Improvement
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Priority: Trivial
There are a couple of LOG.debug statements in the client package that are not in an if block under isDebugEnabled(). They are invoked frequently, so they affect performance.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-32) Clean up LOG.debug statements
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated BOOKKEEPER-32:
-------------------------------
Component/s: bookkeeper-server
bookkeeper-client
Priority: Major (was: Trivial)
Some of these are pretty egregious: for example, BookieServer is toString'ing binary data in READENTRY (which is never acceptable), and additionally doing it regardless of whether debug logging is enabled.
> Clean up LOG.debug statements
> -----------------------------
>
> Key: BOOKKEEPER-32
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-32
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
>
> There are a couple of LOG.debug statements in the client package that are not in an if block under isDebugEnabled(). They are invoked frequently, so they affect performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-32) Clean up LOG.debug statements
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-32:
--------------------------------
Attachment: BOOKKEEPER-32.patch
> Clean up LOG.debug statements
> -----------------------------
>
> Key: BOOKKEEPER-32
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-32
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Flavio Junqueira
> Assignee: Stu Hood
> Fix For: 4.2.0
>
> Attachments: 32.diff, BOOKKEEPER-32.patch
>
>
> There are a couple of LOG.debug statements in the client package that are not in an if block under isDebugEnabled(). They are invoked frequently, so they affect performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-32) Clean up LOG.debug statements
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated BOOKKEEPER-32:
-------------------------------
Attachment: 32.diff
Ok, correction: only the toString'ing of binary data in BookieServer was actually that bad: moved that one into a trace-level conditional, and had it log hex rather than raw binary data.
More than 95% of statements were being properly wrapped, but in many cases there was wrapping where it was unnecessary (ie, for logging of 0/1/2 zero-cost arguments.)
> Clean up LOG.debug statements
> -----------------------------
>
> Key: BOOKKEEPER-32
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-32
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Flavio Junqueira
> Assignee: Stu Hood
> Attachments: 32.diff
>
>
> There are a couple of LOG.debug statements in the client package that are not in an if block under isDebugEnabled(). They are invoked frequently, so they affect performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (BOOKKEEPER-32) Clean up LOG.debug statements
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood reassigned BOOKKEEPER-32:
----------------------------------
Assignee: Stu Hood (was: Flavio Junqueira)
> Clean up LOG.debug statements
> -----------------------------
>
> Key: BOOKKEEPER-32
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-32
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Flavio Junqueira
> Assignee: Stu Hood
>
> There are a couple of LOG.debug statements in the client package that are not in an if block under isDebugEnabled(). They are invoked frequently, so they affect performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-32) Clean up LOG.debug statements
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455773#comment-13455773 ]
Sijie Guo commented on BOOKKEEPER-32:
-------------------------------------
the patch is quite straightforward and looks good. +1 for the patch. will commit it later.
> Clean up LOG.debug statements
> -----------------------------
>
> Key: BOOKKEEPER-32
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-32
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Flavio Junqueira
> Assignee: Stu Hood
> Fix For: 4.2.0
>
> Attachments: 32.diff
>
>
> There are a couple of LOG.debug statements in the client package that are not in an if block under isDebugEnabled(). They are invoked frequently, so they affect performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-32) Clean up LOG.debug statements
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455843#comment-13455843 ]
Hudson commented on BOOKKEEPER-32:
----------------------------------
Integrated in bookkeeper-trunk #711 (See [https://builds.apache.org/job/bookkeeper-trunk/711/])
BOOKKEEPER-32: Clean up LOG.debug statements (Stu Hood via sijie) (Revision 1384782)
Result = SUCCESS
sijie :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/pom.xml
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/MessageConsumeCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/PubSubCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeReconnectCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/ConnectCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigClientImpl.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigPublisher.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/ResponseHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/WriteCallback.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/netty/UmbrellaHandler.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/BookkeeperPersistenceManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/CacheValue.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/AbstractTopicManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkHubServerManager.java
> Clean up LOG.debug statements
> -----------------------------
>
> Key: BOOKKEEPER-32
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-32
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Flavio Junqueira
> Assignee: Stu Hood
> Fix For: 4.2.0
>
> Attachments: 32.diff, BOOKKEEPER-32.patch
>
>
> There are a couple of LOG.debug statements in the client package that are not in an if block under isDebugEnabled(). They are invoked frequently, so they affect performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-32) Clean up LOG.debug statements
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-32:
---------------------------------
Fix Version/s: 4.2.0
> Clean up LOG.debug statements
> -----------------------------
>
> Key: BOOKKEEPER-32
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-32
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Flavio Junqueira
> Assignee: Stu Hood
> Fix For: 4.2.0
>
> Attachments: 32.diff
>
>
> There are a couple of LOG.debug statements in the client package that are not in an if block under isDebugEnabled(). They are invoked frequently, so they affect performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira