You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Malcolm Rowe <ma...@farside.org.uk> on 2006/04/10 19:03:37 UTC

[PATCH] mailer.py: Add Content-Transfer-Encoding

Does the attached patch make sense?  I've not tested it, just cargo-culted
it across from commit-email.{pl.in,rb}.

At the moment my mailserver (Courier) whines whenever I get a commit
message that contains non-ASCII text (which is actually a fair number
of them).

[[[
* tools/hook-scripts/mailer/mailer.py
  (MailedOutput.mail_headers): Add a 'Content-Transfer-Encoding: 8bit'
    header to go with the UTF-8 content-type, so that the message can
    legally contain 8-bit characters.
]]]

Regards,
Malcolm

Re: [PATCH] mailer.py: Add Content-Transfer-Encoding

Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Wed, Apr 12, 2006 at 10:21:44AM -0400, C. Michael Pilato wrote:
> Malcolm Rowe wrote:
> > On Tue, Apr 11, 2006 at 03:03:01PM -0400, C. Michael Pilato wrote:
> >>This makes sense to me.  +1 to commit.
> > 
> > r19319, thanks, and proposed for backport to 1.3.2 (though if someone
> > could patch the version on svn.collab.net before we release 1.3.2,
> > that'd be great too :-)).
> 
> Granted.  r19319 of mailer.py is running on svn.collab.net now.
> 

Now that's service!  Thanks, looks great from here so far.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] mailer.py: Add Content-Transfer-Encoding

Posted by "C. Michael Pilato" <cm...@collab.net>.
Malcolm Rowe wrote:
> On Tue, Apr 11, 2006 at 03:03:01PM -0400, C. Michael Pilato wrote:
> 
>>This makes sense to me.  +1 to commit.
> 
> r19319, thanks, and proposed for backport to 1.3.2 (though if someone
> could patch the version on svn.collab.net before we release 1.3.2,
> that'd be great too :-)).

Granted.  r19319 of mailer.py is running on svn.collab.net now.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Re: [PATCH] mailer.py: Add Content-Transfer-Encoding

Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Tue, Apr 11, 2006 at 03:03:01PM -0400, C. Michael Pilato wrote:
> This makes sense to me.  +1 to commit.
> 

r19319, thanks, and proposed for backport to 1.3.2 (though if someone
could patch the version on svn.collab.net before we release 1.3.2,
that'd be great too :-)).

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] mailer.py: Add Content-Transfer-Encoding

Posted by "C. Michael Pilato" <cm...@collab.net>.
Malcolm Rowe wrote:
> Does the attached patch make sense?  I've not tested it, just cargo-culted
> it across from commit-email.{pl.in,rb}.
> 
> At the moment my mailserver (Courier) whines whenever I get a commit
> message that contains non-ASCII text (which is actually a fair number
> of them).
> 
> [[[
> * tools/hook-scripts/mailer/mailer.py
>   (MailedOutput.mail_headers): Add a 'Content-Transfer-Encoding: 8bit'
>     header to go with the UTF-8 content-type, so that the message can
>     legally contain 8-bit characters.
> ]]]

This makes sense to me.  +1 to commit.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand