You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/11/06 20:55:52 UTC

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #997: [HUDI-302]: simplified countInstants() method in HoodieDefaultTimeline

vinothchandar commented on a change in pull request #997: [HUDI-302]: simplified countInstants() method in HoodieDefaultTimeline
URL: https://github.com/apache/incubator-hudi/pull/997#discussion_r343322703
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java
 ##########
 @@ -141,7 +141,7 @@ public boolean empty() {
 
   @Override
   public int countInstants() {
-    return new Long(instants.stream().count()).intValue();
+    return instants.size();
 
 Review comment:
   holy cow. :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services