[jira] [Commented] (CASSANDRA-12062) Prevent key invalidation if there's no key to invalidate

["Joshua McKenzie (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353479#comment-15353479 ] 

Joshua McKenzie commented on CASSANDRA-12062:
---------------------------------------------

+1. Doesn't obfuscate the code's intent at all so no harm in adding it even w/out #'s.

> Prevent key invalidation if there's no key to invalidate
> --------------------------------------------------------
>
>                 Key: CASSANDRA-12062
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12062
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Minor
>             Fix For: 3.x
>
>
> In {{SSTableRewriter}} we currently assume that there are keys to be invalidated in the key cache. That's not always true - especially if a bunch of tiny sstables have been generated.
> Patch saves one {{synchronized}} and a few objects if that's the case.
> Just a small optimisation, but maybe worth to include.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)