You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Mike Tutkowski <mi...@solidfire.com> on 2014/07/13 07:01:04 UTC
Question about Global Settings
Hi,
I'm doing a code review and had a question that I thought someone might be
able to answer for me:
Do we typically allow vendor-specific config values in Global Settings?
Thanks!
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*
Re: Question about Global Settings
Posted by Erik Weber <te...@gmail.com>.
We have midonet-specific settings in there, wouldn't that be vendor
specific? I'm totally unfamiliar with midonet, so I have to ask.
Erik
13. juli 2014 07:01 skrev "Mike Tutkowski" <mi...@solidfire.com>
følgende:
> Hi,
>
> I'm doing a code review and had a question that I thought someone might be
> able to answer for me:
>
> Do we typically allow vendor-specific config values in Global Settings?
>
> Thanks!
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> <http://solidfire.com/solution/overview/?video=play>*™*
>
Re: Question about Global Settings
Posted by Suresh Ramamurthy <su...@nuagenetworks.net>.
Hi Alena,
Thanks for pointing out the document about global properties. I have
updated NuageVsp plugin to use global properties as mentioned in the
document.
Thanks
Suresh Ramamurthy
On Mon, Jul 14, 2014 at 10:54 AM, Alena Prokharchyk <
Alena.Prokharchyk@citrix.com> wrote:
> Great. Forgot to mention obvious thing - when follow the implementation
> from the doc, if the plugin is not loaded during the install/setup, the
> config will never get inserted to the cloud.configuration table.
>
> -Alena.
>
> On 7/14/14, 10:45 AM, "Mike Tutkowski" <mi...@solidfire.com>
> wrote:
>
> >Thanks, Alena! This is exactly what I was wondering about.
> >
> >I can put this in my code review.
> >
> >
> >On Mon, Jul 14, 2014 at 10:42 AM, Alena Prokharchyk <
> >Alena.Prokharchyk@citrix.com> wrote:
> >
> >> Mike, may be you already know this info, putting it here in case someone
> >> is not aware of that. When global config variables are plugin specific,
> >> they have to inserted by the manager from your plugin; they should never
> >> be put to Config.java class.
> >>
> >> To implement it, make your manager implement Configurable.java. Here is
> >> the FS explaining it in more details:
> >> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuration
> >>
> >> -Alena.
> >>
> >> On 7/14/14, 1:47 AM, "Daan Hoogland" <da...@gmail.com> wrote:
> >>
> >> >If we do that we must provide uninstall/downgrade mechs as well.
> >> >
> >> >On Mon, Jul 14, 2014 at 7:02 AM, Amit Das <am...@cloudbyte.com>
> >>wrote:
> >> >>> Ideally you would want to create db schema/configurations related
> >>to a
> >> >>> plugin only if it is installed/used.
> >> >>
> >> >>
> >> >> Agree completely. A plugin specific settings should be triggered from
> >> >> plugin code the moment the specific plugin is loaded.
> >> >>
> >> >>
> >> >> Regards,
> >> >> Amit
> >> >> *CloudByte Inc.* <http://www.cloudbyte.com/>
> >> >>
> >> >>
> >> >> On Mon, Jul 14, 2014 at 9:46 AM, Koushik Das <koushik.das@citrix.com
> >
> >> >>wrote:
> >> >>
> >> >>> I don't see any issues using vendor/plugin specific settings as
> >>long as
> >> >>> its use is limited to the plugin code.
> >> >>>
> >> >>> But there is limitations in the framework related to the way plugin
> >> >>> specific stuff is handled. Ideally you would want to create db
> >> >>> schema/configurations related to a plugin only if it is
> >> >>>installed/used. But
> >> >>> currently thats not the case, all plugin schemas are always created.
> >> >>>
> >> >>>
> >> >>> On 13-Jul-2014, at 10:31 AM, Mike Tutkowski
> >> >>><mi...@solidfire.com>
> >> >>> wrote:
> >> >>>
> >> >>> > Hi,
> >> >>> >
> >> >>> > I'm doing a code review and had a question that I thought someone
> >> >>>might
> >> >>> be
> >> >>> > able to answer for me:
> >> >>> >
> >> >>> > Do we typically allow vendor-specific config values in Global
> >> >>>Settings?
> >> >>> >
> >> >>> > Thanks!
> >> >>> >
> >> >>> > --
> >> >>> > *Mike Tutkowski*
> >> >>> > *Senior CloudStack Developer, SolidFire Inc.*
> >> >>> > e: mike.tutkowski@solidfire.com
> >> >>> > o: 303.746.7302
> >> >>> > Advancing the way the world uses the cloud
> >> >>> > <http://solidfire.com/solution/overview/?video=play>* *
> >> >>>
> >> >>>
> >> >
> >> >
> >> >
> >> >--
> >> >Daan
> >>
> >>
> >
> >
> >--
> >*Mike Tutkowski*
> >*Senior CloudStack Developer, SolidFire Inc.*
> >e: mike.tutkowski@solidfire.com
> >o: 303.746.7302
> >Advancing the way the world uses the cloud
> ><http://solidfire.com/solution/overview/?video=play>* *
>
>
Re: Question about Global Settings
Posted by Alena Prokharchyk <Al...@citrix.com>.
Great. Forgot to mention obvious thing - when follow the implementation
from the doc, if the plugin is not loaded during the install/setup, the
config will never get inserted to the cloud.configuration table.
-Alena.
On 7/14/14, 10:45 AM, "Mike Tutkowski" <mi...@solidfire.com>
wrote:
>Thanks, Alena! This is exactly what I was wondering about.
>
>I can put this in my code review.
>
>
>On Mon, Jul 14, 2014 at 10:42 AM, Alena Prokharchyk <
>Alena.Prokharchyk@citrix.com> wrote:
>
>> Mike, may be you already know this info, putting it here in case someone
>> is not aware of that. When global config variables are plugin specific,
>> they have to inserted by the manager from your plugin; they should never
>> be put to Config.java class.
>>
>> To implement it, make your manager implement Configurable.java. Here is
>> the FS explaining it in more details:
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuration
>>
>> -Alena.
>>
>> On 7/14/14, 1:47 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>>
>> >If we do that we must provide uninstall/downgrade mechs as well.
>> >
>> >On Mon, Jul 14, 2014 at 7:02 AM, Amit Das <am...@cloudbyte.com>
>>wrote:
>> >>> Ideally you would want to create db schema/configurations related
>>to a
>> >>> plugin only if it is installed/used.
>> >>
>> >>
>> >> Agree completely. A plugin specific settings should be triggered from
>> >> plugin code the moment the specific plugin is loaded.
>> >>
>> >>
>> >> Regards,
>> >> Amit
>> >> *CloudByte Inc.* <http://www.cloudbyte.com/>
>> >>
>> >>
>> >> On Mon, Jul 14, 2014 at 9:46 AM, Koushik Das <ko...@citrix.com>
>> >>wrote:
>> >>
>> >>> I don't see any issues using vendor/plugin specific settings as
>>long as
>> >>> its use is limited to the plugin code.
>> >>>
>> >>> But there is limitations in the framework related to the way plugin
>> >>> specific stuff is handled. Ideally you would want to create db
>> >>> schema/configurations related to a plugin only if it is
>> >>>installed/used. But
>> >>> currently thats not the case, all plugin schemas are always created.
>> >>>
>> >>>
>> >>> On 13-Jul-2014, at 10:31 AM, Mike Tutkowski
>> >>><mi...@solidfire.com>
>> >>> wrote:
>> >>>
>> >>> > Hi,
>> >>> >
>> >>> > I'm doing a code review and had a question that I thought someone
>> >>>might
>> >>> be
>> >>> > able to answer for me:
>> >>> >
>> >>> > Do we typically allow vendor-specific config values in Global
>> >>>Settings?
>> >>> >
>> >>> > Thanks!
>> >>> >
>> >>> > --
>> >>> > *Mike Tutkowski*
>> >>> > *Senior CloudStack Developer, SolidFire Inc.*
>> >>> > e: mike.tutkowski@solidfire.com
>> >>> > o: 303.746.7302
>> >>> > Advancing the way the world uses the cloud
>> >>> > <http://solidfire.com/solution/overview/?video=play>* *
>> >>>
>> >>>
>> >
>> >
>> >
>> >--
>> >Daan
>>
>>
>
>
>--
>*Mike Tutkowski*
>*Senior CloudStack Developer, SolidFire Inc.*
>e: mike.tutkowski@solidfire.com
>o: 303.746.7302
>Advancing the way the world uses the cloud
><http://solidfire.com/solution/overview/?video=play>**
Re: Question about Global Settings
Posted by Mike Tutkowski <mi...@solidfire.com>.
Thanks, Alena! This is exactly what I was wondering about.
I can put this in my code review.
On Mon, Jul 14, 2014 at 10:42 AM, Alena Prokharchyk <
Alena.Prokharchyk@citrix.com> wrote:
> Mike, may be you already know this info, putting it here in case someone
> is not aware of that. When global config variables are plugin specific,
> they have to inserted by the manager from your plugin; they should never
> be put to Config.java class.
>
> To implement it, make your manager implement Configurable.java. Here is
> the FS explaining it in more details:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuration
>
> -Alena.
>
> On 7/14/14, 1:47 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>
> >If we do that we must provide uninstall/downgrade mechs as well.
> >
> >On Mon, Jul 14, 2014 at 7:02 AM, Amit Das <am...@cloudbyte.com> wrote:
> >>> Ideally you would want to create db schema/configurations related to a
> >>> plugin only if it is installed/used.
> >>
> >>
> >> Agree completely. A plugin specific settings should be triggered from
> >> plugin code the moment the specific plugin is loaded.
> >>
> >>
> >> Regards,
> >> Amit
> >> *CloudByte Inc.* <http://www.cloudbyte.com/>
> >>
> >>
> >> On Mon, Jul 14, 2014 at 9:46 AM, Koushik Das <ko...@citrix.com>
> >>wrote:
> >>
> >>> I don't see any issues using vendor/plugin specific settings as long as
> >>> its use is limited to the plugin code.
> >>>
> >>> But there is limitations in the framework related to the way plugin
> >>> specific stuff is handled. Ideally you would want to create db
> >>> schema/configurations related to a plugin only if it is
> >>>installed/used. But
> >>> currently thats not the case, all plugin schemas are always created.
> >>>
> >>>
> >>> On 13-Jul-2014, at 10:31 AM, Mike Tutkowski
> >>><mi...@solidfire.com>
> >>> wrote:
> >>>
> >>> > Hi,
> >>> >
> >>> > I'm doing a code review and had a question that I thought someone
> >>>might
> >>> be
> >>> > able to answer for me:
> >>> >
> >>> > Do we typically allow vendor-specific config values in Global
> >>>Settings?
> >>> >
> >>> > Thanks!
> >>> >
> >>> > --
> >>> > *Mike Tutkowski*
> >>> > *Senior CloudStack Developer, SolidFire Inc.*
> >>> > e: mike.tutkowski@solidfire.com
> >>> > o: 303.746.7302
> >>> > Advancing the way the world uses the cloud
> >>> > <http://solidfire.com/solution/overview/?video=play>* *
> >>>
> >>>
> >
> >
> >
> >--
> >Daan
>
>
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*
Re: Question about Global Settings
Posted by Alena Prokharchyk <Al...@citrix.com>.
Mike, may be you already know this info, putting it here in case someone
is not aware of that. When global config variables are plugin specific,
they have to inserted by the manager from your plugin; they should never
be put to Config.java class.
To implement it, make your manager implement Configurable.java. Here is
the FS explaining it in more details:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuration
-Alena.
On 7/14/14, 1:47 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>If we do that we must provide uninstall/downgrade mechs as well.
>
>On Mon, Jul 14, 2014 at 7:02 AM, Amit Das <am...@cloudbyte.com> wrote:
>>> Ideally you would want to create db schema/configurations related to a
>>> plugin only if it is installed/used.
>>
>>
>> Agree completely. A plugin specific settings should be triggered from
>> plugin code the moment the specific plugin is loaded.
>>
>>
>> Regards,
>> Amit
>> *CloudByte Inc.* <http://www.cloudbyte.com/>
>>
>>
>> On Mon, Jul 14, 2014 at 9:46 AM, Koushik Das <ko...@citrix.com>
>>wrote:
>>
>>> I don't see any issues using vendor/plugin specific settings as long as
>>> its use is limited to the plugin code.
>>>
>>> But there is limitations in the framework related to the way plugin
>>> specific stuff is handled. Ideally you would want to create db
>>> schema/configurations related to a plugin only if it is
>>>installed/used. But
>>> currently thats not the case, all plugin schemas are always created.
>>>
>>>
>>> On 13-Jul-2014, at 10:31 AM, Mike Tutkowski
>>><mi...@solidfire.com>
>>> wrote:
>>>
>>> > Hi,
>>> >
>>> > I'm doing a code review and had a question that I thought someone
>>>might
>>> be
>>> > able to answer for me:
>>> >
>>> > Do we typically allow vendor-specific config values in Global
>>>Settings?
>>> >
>>> > Thanks!
>>> >
>>> > --
>>> > *Mike Tutkowski*
>>> > *Senior CloudStack Developer, SolidFire Inc.*
>>> > e: mike.tutkowski@solidfire.com
>>> > o: 303.746.7302
>>> > Advancing the way the world uses the cloud
>>> > <http://solidfire.com/solution/overview/?video=play>**
>>>
>>>
>
>
>
>--
>Daan
Re: Question about Global Settings
Posted by Daan Hoogland <da...@gmail.com>.
If we do that we must provide uninstall/downgrade mechs as well.
On Mon, Jul 14, 2014 at 7:02 AM, Amit Das <am...@cloudbyte.com> wrote:
>> Ideally you would want to create db schema/configurations related to a
>> plugin only if it is installed/used.
>
>
> Agree completely. A plugin specific settings should be triggered from
> plugin code the moment the specific plugin is loaded.
>
>
> Regards,
> Amit
> *CloudByte Inc.* <http://www.cloudbyte.com/>
>
>
> On Mon, Jul 14, 2014 at 9:46 AM, Koushik Das <ko...@citrix.com> wrote:
>
>> I don't see any issues using vendor/plugin specific settings as long as
>> its use is limited to the plugin code.
>>
>> But there is limitations in the framework related to the way plugin
>> specific stuff is handled. Ideally you would want to create db
>> schema/configurations related to a plugin only if it is installed/used. But
>> currently thats not the case, all plugin schemas are always created.
>>
>>
>> On 13-Jul-2014, at 10:31 AM, Mike Tutkowski <mi...@solidfire.com>
>> wrote:
>>
>> > Hi,
>> >
>> > I'm doing a code review and had a question that I thought someone might
>> be
>> > able to answer for me:
>> >
>> > Do we typically allow vendor-specific config values in Global Settings?
>> >
>> > Thanks!
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkowski@solidfire.com
>> > o: 303.746.7302
>> > Advancing the way the world uses the cloud
>> > <http://solidfire.com/solution/overview/?video=play>*™*
>>
>>
--
Daan
Re: Question about Global Settings
Posted by Amit Das <am...@cloudbyte.com>.
> Ideally you would want to create db schema/configurations related to a
> plugin only if it is installed/used.
Agree completely. A plugin specific settings should be triggered from
plugin code the moment the specific plugin is loaded.
Regards,
Amit
*CloudByte Inc.* <http://www.cloudbyte.com/>
On Mon, Jul 14, 2014 at 9:46 AM, Koushik Das <ko...@citrix.com> wrote:
> I don't see any issues using vendor/plugin specific settings as long as
> its use is limited to the plugin code.
>
> But there is limitations in the framework related to the way plugin
> specific stuff is handled. Ideally you would want to create db
> schema/configurations related to a plugin only if it is installed/used. But
> currently thats not the case, all plugin schemas are always created.
>
>
> On 13-Jul-2014, at 10:31 AM, Mike Tutkowski <mi...@solidfire.com>
> wrote:
>
> > Hi,
> >
> > I'm doing a code review and had a question that I thought someone might
> be
> > able to answer for me:
> >
> > Do we typically allow vendor-specific config values in Global Settings?
> >
> > Thanks!
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkowski@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > <http://solidfire.com/solution/overview/?video=play>*™*
>
>
Re: Question about Global Settings
Posted by Koushik Das <ko...@citrix.com>.
I don't see any issues using vendor/plugin specific settings as long as its use is limited to the plugin code.
But there is limitations in the framework related to the way plugin specific stuff is handled. Ideally you would want to create db schema/configurations related to a plugin only if it is installed/used. But currently thats not the case, all plugin schemas are always created.
On 13-Jul-2014, at 10:31 AM, Mike Tutkowski <mi...@solidfire.com> wrote:
> Hi,
>
> I'm doing a code review and had a question that I thought someone might be
> able to answer for me:
>
> Do we typically allow vendor-specific config values in Global Settings?
>
> Thanks!
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> <http://solidfire.com/solution/overview/?video=play>*™*