You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/22 22:19:02 UTC
[GitHub] [airflow] ashb opened a new pull request #11753: Fix FAB actions with for models with composite PKs
ashb opened a new pull request #11753:
URL: https://github.com/apache/airflow/pull/11753
This fixes #11513 -- and has been submitted upstream to FAB as
https://github.com/dpgaspar/Flask-AppBuilder/pull/1493, once that is
merged we can remove this
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11753: Fix FAB actions with for models with composite PKs
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11753:
URL: https://github.com/apache/airflow/pull/11753#discussion_r510490921
##########
File path: airflow/www/utils.py
##########
@@ -437,6 +439,42 @@ def is_utcdatetime(self, col_name):
isinstance(obj.impl, UtcDateTime)
return False
+ # This is a local fix until https://github.com/dpgaspar/Flask-AppBuilder/pull/1493 is merged and released.
+ def get(
+ self,
+ id,
+ filters: Optional[Filters] = None,
+ select_columns: Optional[List[str]] = None,
+ ) -> Any:
+ """
+ Returns the result for a model get, applies filters and supports dotted
+ notation for joins and granular selecting query columns.
+ :param id: The model id (pk).
Review comment:
```suggestion
notation for joins and granular selecting query columns.
:param id: The model id (pk).
```
##########
File path: airflow/www/utils.py
##########
@@ -437,6 +439,42 @@ def is_utcdatetime(self, col_name):
isinstance(obj.impl, UtcDateTime)
return False
+ # This is a local fix until https://github.com/dpgaspar/Flask-AppBuilder/pull/1493 is merged and released.
+ def get(
+ self,
+ id,
+ filters: Optional[Filters] = None,
+ select_columns: Optional[List[str]] = None,
+ ) -> Any:
+ """
+ Returns the result for a model get, applies filters and supports dotted
+ notation for joins and granular selecting query columns.
+ :param id: The model id (pk).
+ :param filters: A Filter class that contains all filters to apply.
+ :param select_columns: A List of columns to be specifically selected.
+ on the query. Supports dotted notation.
+ :return:
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11753: Fix FAB actions with for models with composite PKs
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11753:
URL: https://github.com/apache/airflow/pull/11753#discussion_r510681213
##########
File path: airflow/www/utils.py
##########
@@ -437,6 +439,42 @@ def is_utcdatetime(self, col_name):
isinstance(obj.impl, UtcDateTime)
return False
+ # This is a local fix until https://github.com/dpgaspar/Flask-AppBuilder/pull/1493 is merged and released.
+ def get(
+ self,
+ id,
+ filters: Optional[Filters] = None,
+ select_columns: Optional[List[str]] = None,
+ ) -> Any:
+ """
+ Returns the result for a model get, applies filters and supports dotted
+ notation for joins and granular selecting query columns.
+ :param id: The model id (pk).
Review comment:
Probably - I just wholesale copied it from FAB
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11753: Fix FAB actions with for models with composite PKs
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11753:
URL: https://github.com/apache/airflow/pull/11753#discussion_r510491070
##########
File path: airflow/www/utils.py
##########
@@ -437,6 +439,42 @@ def is_utcdatetime(self, col_name):
isinstance(obj.impl, UtcDateTime)
return False
+ # This is a local fix until https://github.com/dpgaspar/Flask-AppBuilder/pull/1493 is merged and released.
+ def get(
+ self,
+ id,
+ filters: Optional[Filters] = None,
+ select_columns: Optional[List[str]] = None,
+ ) -> Any:
+ """
+ Returns the result for a model get, applies filters and supports dotted
+ notation for joins and granular selecting query columns.
+ :param id: The model id (pk).
Review comment:
docstyle _might_ complain
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #11753: Fix FAB actions with for models with composite PKs
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #11753:
URL: https://github.com/apache/airflow/pull/11753
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org