[GitHub] [geode] bschuchardt commented on a change in pull request #5984: GEODE-8901: Surviving side server forcefully disconnected after network drop

[GitBox <gi...@apache.org>]

bschuchardt commented on a change in pull request #5984:
URL: https://github.com/apache/geode/pull/5984#discussion_r569626758



##########
File path: geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java
##########
@@ -1454,10 +1454,14 @@ void processMessage(NetworkPartitionMessage<ID> msg) {
     if (isStopping) {
       return;
     }
-
-    String str = "Membership coordinator " + msg.getSender()
-        + " has declared that a network partition has occurred";
-    forceDisconnect(str);
+    ID sender = msg.getSender();
+    if (getView().getMembers().contains(sender) || getView().getViewId() == sender.getVmViewId()) {

Review comment:
       I don't understand the reason for the viewId check you've added here.  Would you please elaborate?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org