You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/23 10:22:05 UTC
[GitHub] [flink] wangyang0918 opened a new pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
wangyang0918 opened a new pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Currently, we start minikube in `nightly.sh` for every e2e test, and it will never be stopped. It is unnecessary and will occupy some resources on travis. I think the minikube should only be started in the kubernetes related test(`test_kubernetes_embedded_job.sh` and `test_kubernetes_session.sh`) and need to be stopped once the test finished.
## Brief change log
* Use stable api apps/v1 instead of extensions/v1beta1
* Remove starting minikube from`nightly.sh` and move to `common_kubernetes.sh`
## Verifying this change
* The changes are covered by e2e tests `test_kubernetes_embedded_job.sh` and `test_kubernetes_session.sh`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365354033
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -26,26 +26,56 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
+# If running tests on non-linux os, the kubectl and minikube should be installed manually
+function setup_kubernetes_for_linux {
+ # Download kubectl, which is a requirement for using minikube.
+ if ! [ -x "$(command -v kubectl)" ]; then
+ local version=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/$version/bin/linux/amd64/kubectl && \
+ chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ fi
+ # Download minikube.
+ if ! [ -x "$(command -v minikube)" ]; then
+ curl -Lo minikube https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 && \
+ chmod +x minikube && sudo mv minikube /usr/local/bin/
Review comment:
Same here with `sudo`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143714109 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144091754 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144091754 TriggerType:MANUAL TriggerID:573558614
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714109) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219)
* 677c4fcd1b82c766f79e296883f8464daafb6a44 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144091754) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10665: [FLINK-15354] Start and
stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10665: [FLINK-15354] Start and
stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568433289
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5a0d5d3d499347ca216e19175ff5f066a6d9b458 (Mon Dec 23 10:25:00 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15354).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 edited a comment on issue #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-573550858
```
05:36:27.122 [INFO] ------------------------------------------------------------------------
05:36:27.124 [ERROR] Failed to execute goal org.scalastyle:scalastyle-maven-plugin:1.0.0:check (default) on project flink-runtime_2.11: Execution default of goal org.scalastyle:scalastyle-maven-plugin:1.0.0:check failed: Plugin org.scalastyle:scalastyle-maven-plugin:1.0.0 or one of its dependencies could not be resolved: Could not transfer artifact org.scala-lang:scala-library:jar:2.11.11 from/to google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/): GET request of: org/scala-lang/scala-library/2.11.11/scala-library-2.11.11.jar from google-maven-central failed: Connection reset -> [Help 1]
05:36:27.125 [ERROR]
05:36:27.125 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
05:36:27.125 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
05:36:27.125 [ERROR]
05:36:27.125 [ERROR] For more information about the errors and possible solutions, please read the following articles:
05:36:27.125 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException
05:36:27.125 [ERROR]
05:36:27.125 [ERROR] After correcting the problems, you can resume the build with the command
05:36:27.125 [ERROR] mvn <goals> -rf :flink-runtime_2.11
```
The failed tests are all unrelated with the changes of this PR.
The three tests `e2e - container - hadoop 2.8` `e2e - container - scala 2.12` `e2e - container` could cover the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143714109 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714109) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365636347
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_session.sh
##########
@@ -29,6 +29,7 @@ ARGS="--output ${OUTPUT_PATH}"
function cleanup {
kubectl delete service ${CLUSTER_ID}
kubectl delete clusterrolebinding ${CLUSTER_ROLE_BINDING}
+ stop_kubernetes
Review comment:
Nice suggestion.
If we use `--vm-driver=none` when starting a minikube in linux-like system, it is very fast(less than 5s). Most of the time cost at building the flink image and then running the test. The advantage is we always get a new and clean Kubernetes cluster environment for every test.
BTW, i think the Yarn/Mesos/Kubernetes share the logics. Start a new cluster for each e2e test.
So i will create a follow-up ticket tracking the optimization and it is not urgent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365636347
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_session.sh
##########
@@ -29,6 +29,7 @@ ARGS="--output ${OUTPUT_PATH}"
function cleanup {
kubectl delete service ${CLUSTER_ID}
kubectl delete clusterrolebinding ${CLUSTER_ROLE_BINDING}
+ stop_kubernetes
Review comment:
Nice suggestion. I will create a follow-up ticket to optimize the start/stop of minikube.
BTW, i think the Yarn/Mesos/Kubernetes share the logics. Start a new cluster for each e2e test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143714109 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143714109) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365355603
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
##########
@@ -30,7 +30,7 @@ function cleanup {
kubectl delete job flink-job-cluster
kubectl delete service flink-job-cluster
kubectl delete deployment flink-task-manager
- rm -rf ${OUTPUT_VOLUME}
Review comment:
Does `stop_kubernetes` delete the `${OUTPUT_VOLUME}`? Or why is this no longer needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143714109 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144091754 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144091754 TriggerType:MANUAL TriggerID:573558614
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278 TriggerType:MANUAL TriggerID:573558614
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714109) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219)
* 677c4fcd1b82c766f79e296883f8464daafb6a44 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144091754) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 edited a comment on issue #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-573550858
```
05:36:27.124 [ERROR] Failed to execute goal org.scalastyle:scalastyle-maven-plugin:1.0.0:check (default) on project flink-runtime_2.11: Execution default of goal org.scalastyle:scalastyle-maven-plugin:1.0.0:check failed: Plugin org.scalastyle:scalastyle-maven-plugin:1.0.0 or one of its dependencies could not be resolved: Could not transfer artifact org.scala-lang:scala-library:jar:2.11.11 from/to google-maven-central (https://maven-central.storage-download.googleapis.com/maven2/): GET request of: org/scala-lang/scala-library/2.11.11/scala-library-2.11.11.jar from google-maven-central failed: Connection reset -> [Help 1]
```
The failed tests are all unrelated with the changes of this PR.
The three tests `e2e - container - hadoop 2.8` `e2e - container - scala 2.12` `e2e - container` could cover the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10665: [FLINK-15354] Start
and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568446397
@tillrohrmann According to our discussion under #10602, i create this PR to only start/stop minikube in kubernetes related e2e tests. This will make other e2e tests faster and cost fewer resources. Please take a loot at your convenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10665: [FLINK-15354] Start
and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568486313
https://travis-ci.org/wangyang0918/flink/builds/628670214
The e2e tests could pass. Kubernetes related tests `test_kubernetes_embedded_job.sh` and `test_kubernetes_session.sh` cost about 2 minutes just like before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365635088
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -26,26 +26,56 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
+# If running tests on non-linux os, the kubectl and minikube should be installed manually
+function setup_kubernetes_for_linux {
+ # Download kubectl, which is a requirement for using minikube.
+ if ! [ -x "$(command -v kubectl)" ]; then
+ local version=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/$version/bin/linux/amd64/kubectl && \
+ chmod +x kubectl && sudo mv kubectl /usr/local/bin/
Review comment:
Yeah, we have the `sudo: required` in `.travis.yml`. So we will have the sudo permission without providing password.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143714109 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144091754 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714109) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219)
* 677c4fcd1b82c766f79e296883f8464daafb6a44 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144091754) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143714109 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714109) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219)
* 677c4fcd1b82c766f79e296883f8464daafb6a44 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10665: [FLINK-15354] Start
and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-573550858
The failed tests are all unrelated with the changes of this PR.
The three tests `e2e - container - hadoop 2.8` `e2e - container - scala 2.12` `e2e - container` could cover the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 edited a comment on issue #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568486313
https://travis-ci.org/wangyang0918/flink/builds/628670214
The e2e tests on travis could pass. Kubernetes related tests `test_kubernetes_embedded_job.sh` and `test_kubernetes_session.sh` cost about 2 minutes just like before.
I also run the two tests on my local Mac, they could also work well. Please make sure the minikube has been installed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143714109 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144091754 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714109) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219)
* 677c4fcd1b82c766f79e296883f8464daafb6a44 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144091754) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365354460
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -26,26 +26,56 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
+# If running tests on non-linux os, the kubectl and minikube should be installed manually
+function setup_kubernetes_for_linux {
+ # Download kubectl, which is a requirement for using minikube.
+ if ! [ -x "$(command -v kubectl)" ]; then
+ local version=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/$version/bin/linux/amd64/kubectl && \
+ chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ fi
+ # Download minikube.
+ if ! [ -x "$(command -v minikube)" ]; then
+ curl -Lo minikube https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 && \
+ chmod +x minikube && sudo mv minikube /usr/local/bin/
+ fi
+}
+
function check_kubernetes_status {
minikube status
return $?
}
function start_kubernetes_if_not_running {
if ! check_kubernetes_status; then
- minikube start
+ start_command="minikube start"
+ # We need sudo permission to set vm-driver to none in linux os.
+ [[ "${OS_TYPE}" = "linux" ]] && start_command="sudo ${start_command} --vm-driver=none"
Review comment:
Can we always assume that we have sudo rights? If not, then it might be simpler to require that `minikube` and `kubectl` are installed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143714109 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144091754 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144091754 TriggerType:MANUAL TriggerID:573558614
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278 TriggerType:MANUAL TriggerID:573558614
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714109) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219)
* 677c4fcd1b82c766f79e296883f8464daafb6a44 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144091754) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365635974
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
##########
@@ -30,7 +30,7 @@ function cleanup {
kubectl delete job flink-job-cluster
kubectl delete service flink-job-cluster
kubectl delete deployment flink-task-manager
- rm -rf ${OUTPUT_VOLUME}
Review comment:
The `${OUTPUT_VOLUME}` is under `${TEST_DATA_DIR}`. And `${TEST_DATA_DIR}` will be cleaned up automatically when the e2e test finished. See `test-runner-common.sh#cleanup`.
I will add a hotfix to remove this line. Then it will be more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143714109 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143714109) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365355152
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -26,26 +26,56 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
+# If running tests on non-linux os, the kubectl and minikube should be installed manually
+function setup_kubernetes_for_linux {
+ # Download kubectl, which is a requirement for using minikube.
+ if ! [ -x "$(command -v kubectl)" ]; then
+ local version=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/$version/bin/linux/amd64/kubectl && \
+ chmod +x kubectl && sudo mv kubectl /usr/local/bin/
Review comment:
Ok I see that this was done before like this as well. Hence, there must be sudo rights.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365354011
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -26,26 +26,56 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
+# If running tests on non-linux os, the kubectl and minikube should be installed manually
+function setup_kubernetes_for_linux {
+ # Download kubectl, which is a requirement for using minikube.
+ if ! [ -x "$(command -v kubectl)" ]; then
+ local version=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/$version/bin/linux/amd64/kubectl && \
+ chmod +x kubectl && sudo mv kubectl /usr/local/bin/
Review comment:
I think we cannot assume that we have sudo rights.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143514708 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179 TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143667456 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:1465ba2465b0fba3c91377735481db17abb1c21f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203 TriggerType:PUSH TriggerID:1465ba2465b0fba3c91377735481db17abb1c21f
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143714109 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:76f3dadc5062279dda9df063901a548315a8b8da Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219 TriggerType:PUSH TriggerID:76f3dadc5062279dda9df063901a548315a8b8da
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144091754 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
Hash:677c4fcd1b82c766f79e296883f8464daafb6a44 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278 TriggerType:PUSH TriggerID:677c4fcd1b82c766f79e296883f8464daafb6a44
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143514708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4179)
* 1465ba2465b0fba3c91377735481db17abb1c21f Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143667456) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4203)
* 76f3dadc5062279dda9df063901a548315a8b8da Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143714109) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4219)
* 677c4fcd1b82c766f79e296883f8464daafb6a44 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144091754) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4278)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10665: [FLINK-15354]
Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-568440738
<!--
Meta data
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142099952 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:5a0d5d3d499347ca216e19175ff5f066a6d9b458 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861 TriggerType:PUSH TriggerID:5a0d5d3d499347ca216e19175ff5f066a6d9b458
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:255d89be8069b36be2b980ea6dba4798568160bb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143507134 TriggerType:PUSH TriggerID:255d89be8069b36be2b980ea6dba4798568160bb
Hash:9168102e928bacaa8026407f77a33b80a8ddeae4 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9168102e928bacaa8026407f77a33b80a8ddeae4
-->
## CI report:
* 5a0d5d3d499347ca216e19175ff5f066a6d9b458 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142099952) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3861)
* 255d89be8069b36be2b980ea6dba4798568160bb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143507134) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4176)
* 9168102e928bacaa8026407f77a33b80a8ddeae4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365635600
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -26,26 +26,56 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
+# If running tests on non-linux os, the kubectl and minikube should be installed manually
+function setup_kubernetes_for_linux {
+ # Download kubectl, which is a requirement for using minikube.
+ if ! [ -x "$(command -v kubectl)" ]; then
+ local version=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/$version/bin/linux/amd64/kubectl && \
+ chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ fi
+ # Download minikube.
+ if ! [ -x "$(command -v minikube)" ]; then
+ curl -Lo minikube https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 && \
+ chmod +x minikube && sudo mv minikube /usr/local/bin/
+ fi
+}
+
function check_kubernetes_status {
minikube status
return $?
}
function start_kubernetes_if_not_running {
if ! check_kubernetes_status; then
- minikube start
+ start_command="minikube start"
+ # We need sudo permission to set vm-driver to none in linux os.
+ [[ "${OS_TYPE}" = "linux" ]] && start_command="sudo ${start_command} --vm-driver=none"
Review comment:
When running this test on non-linux environment(e.g. Mac Os), we could not start the minikube under `--vm-driver=none` mode. So we will not need sudo permission. Of course we could use `sudo minikube start` on MacOS, then we need to provide the password interactively.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365635600
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -26,26 +26,56 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
+# If running tests on non-linux os, the kubectl and minikube should be installed manually
+function setup_kubernetes_for_linux {
+ # Download kubectl, which is a requirement for using minikube.
+ if ! [ -x "$(command -v kubectl)" ]; then
+ local version=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ curl -Lo kubectl https://storage.googleapis.com/kubernetes-release/release/$version/bin/linux/amd64/kubectl && \
+ chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ fi
+ # Download minikube.
+ if ! [ -x "$(command -v minikube)" ]; then
+ curl -Lo minikube https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 && \
+ chmod +x minikube && sudo mv minikube /usr/local/bin/
+ fi
+}
+
function check_kubernetes_status {
minikube status
return $?
}
function start_kubernetes_if_not_running {
if ! check_kubernetes_status; then
- minikube start
+ start_command="minikube start"
+ # We need sudo permission to set vm-driver to none in linux os.
+ [[ "${OS_TYPE}" = "linux" ]] && start_command="sudo ${start_command} --vm-driver=none"
Review comment:
When running this test in non-linux environment(e.g. Mac Os), we could not start the minikube under `--vm-driver=none` mode. So we will not need sudo permission. Of course we could use `sudo minikube start` on MacOS, then we need to provide the password interactively. I suggest to run on `non-sudo` mode in non-linux environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10665:
[FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#discussion_r365356272
##########
File path: flink-end-to-end-tests/test-scripts/test_kubernetes_session.sh
##########
@@ -29,6 +29,7 @@ ARGS="--output ${OUTPUT_PATH}"
function cleanup {
kubectl delete service ${CLUSTER_ID}
kubectl delete clusterrolebinding ${CLUSTER_ROLE_BINDING}
+ stop_kubernetes
Review comment:
This means that for every K8s test we start and stop `minikube`. This might add some time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10665: [FLINK-15354] Start
and stop minikube only in kubernetes related e2e tests
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10665: [FLINK-15354] Start and stop minikube only in kubernetes related e2e tests
URL: https://github.com/apache/flink/pull/10665#issuecomment-573558614
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services