You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by de...@apache.org on 2015/06/08 11:28:22 UTC
svn commit: r1684127 - in
/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources:
default/myfaces-checks-standard.xml default/myfaces-checks-strict.xml
tobago/checkstyle-strict.xml tobago/checkstyle.xml
Author: deki
Date: Mon Jun 8 09:28:22 2015
New Revision: 1684127
URL: http://svn.apache.org/r1684127
Log:
MYFACES-3995: Remove DoubleCheckedLockingCheck from checkstyle rules (see MCHECKSTYLE-189)
Modified:
myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-standard.xml
myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-strict.xml
myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle-strict.xml
myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle.xml
Modified: myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-standard.xml
URL: http://svn.apache.org/viewvc/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-standard.xml?rev=1684127&r1=1684126&r2=1684127&view=diff
==============================================================================
--- myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-standard.xml (original)
+++ myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-standard.xml Mon Jun 8 09:28:22 2015
@@ -155,9 +155,6 @@
<!-- Checks for common coding problems -->
<!-- See http://checkstyle.sf.net/config_coding.html -->
- <!-- DISABLED, because DoubleCheckLock is perfectly valid now as of Java5. See JSR-133
- * <module name="DoubleCheckedLocking"/>
- -->
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<module name="InnerAssignment"/>
Modified: myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-strict.xml
URL: http://svn.apache.org/viewvc/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-strict.xml?rev=1684127&r1=1684126&r2=1684127&view=diff
==============================================================================
--- myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-strict.xml (original)
+++ myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/myfaces-checks-strict.xml Mon Jun 8 09:28:22 2015
@@ -149,9 +149,6 @@
<!-- Checks for common coding problems -->
<!-- See http://checkstyle.sf.net/config_coding.html -->
- <!-- DISABLED, because DoubleCheckLock is perfectly valid now as of Java5. See JSR-133
- * <module name="DoubleCheckedLocking"/>
- -->
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<module name="InnerAssignment"/>
Modified: myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle-strict.xml
URL: http://svn.apache.org/viewvc/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle-strict.xml?rev=1684127&r1=1684126&r2=1684127&view=diff
==============================================================================
--- myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle-strict.xml (original)
+++ myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle-strict.xml Mon Jun 8 09:28:22 2015
@@ -171,7 +171,6 @@
<!-- See http://checkstyle.sf.net/config_coding.html -->
<!-- <module name="AvoidInlineConditionals"/> -->
<module name="CovariantEquals"/>
- <module name="DoubleCheckedLocking"/>
<module name="EmptyStatement"/>
<module name="EqualsHashCode"/>
<module name="HiddenField">
Modified: myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle.xml
URL: http://svn.apache.org/viewvc/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle.xml?rev=1684127&r1=1684126&r2=1684127&view=diff
==============================================================================
--- myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle.xml (original)
+++ myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/checkstyle.xml Mon Jun 8 09:28:22 2015
@@ -171,7 +171,6 @@
<!-- See http://checkstyle.sf.net/config_coding.html -->
<!-- <module name="AvoidInlineConditionals"/> -->
<module name="CovariantEquals"/>
- <module name="DoubleCheckedLocking"/>
<!--<module name="EmptyStatement"/>-->
<module name="EqualsHashCode"/>
<!--module name="MissingDeprecated"/-->