You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by lvfangmin <gi...@git.apache.org> on 2018/07/26 01:52:16 UTC
[GitHub] zookeeper pull request #583: [ZOOKEEPER-3104] Fix data inconsistency due to ...
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/583
[ZOOKEEPER-3104] Fix data inconsistency due to NEWLEADER being sent too early
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-3104
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/583.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #583
----
commit 8f181934cecb07350c5b1b50b00f460ad071af6c
Author: Fangmin Lyu <al...@...>
Date: 2018-07-25T16:48:38Z
Fix potential data inconsistency due to NEWLEADER packet being sent too early during SNAP sync
----
---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Posted by maoling <gi...@git.apache.org>.
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/583
@lvfangmin discard your vim,embrace IEDA(smirk)
---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Posted by breed <gi...@git.apache.org>.
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/583
ok @lvfangmin i'll commit this once the conflict is resolved.
---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Posted by nkalmar <gi...@git.apache.org>.
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/583
It's not a blocker for me, I agree it would be nice to have a unified format, but that's pretty hard to achieve on an Apache I think :(
Anyway, that's why I wrote a "comment" review, not a request for change.
Thanks for the fix @lvfangmin ! :)
---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/583
@nkalmar I can remove the white space in this diff, it do looks much cleaner after we remove the space though.
Do you know how often we need to ask people to format their code (remove the extra white space change, etc), maybe we should unify the format of coding and have a one time format to avoid this issue in the future.
Please use "Hide whitespace changes" when reviewing the code before I removed those white space change.
---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Posted by breed <gi...@git.apache.org>.
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/583
@nkalmar i think fixing whitespace is good if it is in proximity of the code you are changing, which i think is the case in this diff.
the logic looks good to me! thanx @lvfangmin !
+1
---
[GitHub] zookeeper pull request #583: [ZOOKEEPER-3104] Fix data inconsistency due to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/583
---
[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/583
Thanks @breed, the conflict is resolved.
---