You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2014/07/02 15:38:15 UTC
[GitHub] incubator-brooklyn pull request: Conditional wrapping of YAML app.
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/39
Conditional wrapping of YAML app.
When loading YAML with a single application in the services list don't
create a wrapper application, use the one from the services list.
To explicitly force wrapping use custom attribute "wrapApp: true".
Original commit review notes:
https://github.com/neykov/incubator-brooklyn/commit/91851deb7c0cbeb0b1d8d94c7df2afcc33744597
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn yaml-promote-app
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit c43eb16fdc209a09f4cc7ee895816298bf48a785
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2014-07-02T09:52:17Z
Conditional wrapping of YAML app.
When loading YAML with a single application in the services list don't
create a wrapper application, use the one from the services list.
To explicitly force wrapping use custom attribute "wrapApp: true".
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Conditional wrapping of YAML app.
Posted by neykov <gi...@git.apache.org>.
Github user neykov closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Conditional wrapping of YAML app.
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/39#issuecomment-48046924
ah there was a merge conflict addressing an `applyLocation` which is why this has not been automatically detected as merged.
this PR is effectively merged by #46, commits f99fb581657840e1761402d073074f4968d3c0b1 and c43eb16fdc209a09f4cc7ee895816298bf48a785
this PR can be closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---