[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43184: [SPARK-44120][PYTHON] Support Python 3.12

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #43184:
URL: https://github.com/apache/spark/pull/43184#discussion_r1342032967


##########
python/pyspark/pandas/tests/indexes/test_base.py:
##########
@@ -17,7 +17,7 @@
 
 import inspect
 import unittest

Review Comment:
   It's not difficult to copy or to reimplement, @HyukjinKwon and @viirya . 
   
   However, it's a PSF License which is different from Py4J or cloudpickle (under BSD 3-Clause), 
   https://github.com/apache/spark/blob/58c24a5719b8717ea37347c668c9df8a3714ae3c/LICENSE-binary#L460-L462
   
   I believe it's compatible but we need to take a look once more before doing that. It's because our Apache Spark binary distribution doesn't include `Python Software Foundation` yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org