[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #17214: [tvmop] support cuda multi-arch compilation

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #17214: [tvmop] support cuda multi-arch compilation
URL: https://github.com/apache/incubator-mxnet/pull/17214#discussion_r363446841
 
 

 ##########
 File path: contrib/tvmop/compile.py
 ##########
 @@ -105,18 +105,13 @@ def get_cuda_arch(arch):
         return arch.split(';')
 
     # the arch string contains '-arch=sm_xx'
+    archs = []
     flags = arch.split()
     for flag in flags:
-        if flag.startswith('-arch='):
-            return flag[len('-arch='):]
+        if flag.startswith('-gencode') or flag.startswith('arch='):
 
 Review comment:
   I believe the example comes from the Makefile setup:
   
   https://github.com/apache/incubator-mxnet/blob/83a23b0988b55c1483f5ecec941207357492bcff/Makefile#L429-L442

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services