You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/14 16:08:04 UTC

[GitHub] [arrow] houqp commented on a change in pull request #7133: ARROW-8744: [Rust] handle channel close in parquet batch iterator

houqp commented on a change in pull request #7133:
URL: https://github.com/apache/arrow/pull/7133#discussion_r425255863



##########
File path: rust/arrow/src/record_batch.rs
##########
@@ -36,7 +36,7 @@ use crate::error::{ArrowError, Result};
 /// serialization and computation functions, possibly incremental.  
 /// See also [CSV reader](crate::csv::Reader) and
 /// [JSON reader](crate::json::Reader).
-#[derive(Clone)]
+#[derive(Clone, Debug)]

Review comment:
       I found it useful to have this trait for debugging purpose. It is not used in the change I made in this PR. I will remove it if the policy is to avoid adding Debug trait unless necessary.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org