You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/28 14:23:58 UTC
[GitHub] [camel] mmajerni opened a new pull request, #7920: [DOCS] Update Bean and FHIR components.
mmajerni opened a new pull request, #7920:
URL: https://github.com/apache/camel/pull/7920
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mmajerni commented on a diff in pull request #7920: [DOCS] Update Bean and FHIR components.
Posted by GitBox <gi...@apache.org>.
mmajerni commented on code in PR #7920:
URL: https://github.com/apache/camel/pull/7920#discussion_r909374781
##########
docs/components/modules/ROOT/partials/component-endpoint-options.adoc:
##########
@@ -70,7 +70,7 @@ ifeval::[{apicount} != 0]
== API Parameters ({apicount} APIs)
-The @{doctitle} endpoint is an API based component and has additional parameters based on which API name and API method is used.
+The {doctitle} endpoint is an API based component and has additional parameters based on which API name and API method is used.
Review Comment:
I thought that it was a typo.
Docs: https://camel.apache.org/components/3.14.x/fhir-component.html#_api_parameters_13_apis
Text: **The @FHIR endpoint is an API based component and has additional ...**
I can reverse the change if it is intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #7920: [DOCS] Update Bean and FHIR components.
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #7920:
URL: https://github.com/apache/camel/pull/7920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7920: [DOCS] Update Bean and FHIR components.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7920:
URL: https://github.com/apache/camel/pull/7920#issuecomment-1169871833
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **2 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #7920: [DOCS] Update Bean and FHIR components.
Posted by GitBox <gi...@apache.org>.
davsclaus commented on code in PR #7920:
URL: https://github.com/apache/camel/pull/7920#discussion_r908744874
##########
docs/components/modules/ROOT/partials/component-endpoint-options.adoc:
##########
@@ -70,7 +70,7 @@ ifeval::[{apicount} != 0]
== API Parameters ({apicount} APIs)
-The @{doctitle} endpoint is an API based component and has additional parameters based on which API name and API method is used.
+The {doctitle} endpoint is an API based component and has additional parameters based on which API name and API method is used.
Review Comment:
Is there a reason for this change? Because it could be that the `@` is on purpose as this is a partials file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #7920: [DOCS] Update Bean and FHIR components.
Posted by GitBox <gi...@apache.org>.
davsclaus commented on code in PR #7920:
URL: https://github.com/apache/camel/pull/7920#discussion_r909292561
##########
docs/components/modules/ROOT/partials/component-endpoint-options.adoc:
##########
@@ -70,7 +70,7 @@ ifeval::[{apicount} != 0]
== API Parameters ({apicount} APIs)
-The @{doctitle} endpoint is an API based component and has additional parameters based on which API name and API method is used.
+The {doctitle} endpoint is an API based component and has additional parameters based on which API name and API method is used.
Review Comment:
@djencks do you know if that `@{doctitle}` have a special meaning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7920: [DOCS] Update Bean and FHIR components.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7920:
URL: https://github.com/apache/camel/pull/7920#issuecomment-1168794656
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org