[jira] [Closed] (CB-560) Cordova breaking iOS plugins

["Chris Brody (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CB-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Brody closed CB-560.
--------------------------

> Cordova breaking iOS plugins
> ----------------------------
>
>                 Key: CB-560
>                 URL: https://issues.apache.org/jira/browse/CB-560
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS
>    Affects Versions: 1.6.1
>         Environment: From https://groups.google.com/forum/?fromgroups#!topic/phonegap/2G5OPKV_FdQ someone apparently tried upgrading from PhoneGap 1.1 to 1.6.
>            Reporter: Chris Brody
>            Assignee: Filip Maj
>             Fix For: 1.7.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> From 1.4 to 1.5, the namespace was changed from PhoneGap to Cordova which was breaking all of the existing plugins. I eventually provided a shim class but it was too late to stop the pain. Then in Javascript only Cordova was changed to cordova, breaking the iOS plugins yet again. I noticed in cordova (1.6.0) JS:
> if (!window.PhoneGap) {
>     window.PhoneGap = cordova;
> }
> This should have been done for Cordova like:
> if (!Cordova) {
>  Cordova = cordova;
> }
> Yes we should be deprecating the old namespaces for removal in another major release. Any API changes made before a major release should be made with a workaround, to be deprecated, and tested with some plugins before shipping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)