[GitHub] [camel-k] squakez commented on a diff in pull request #4659: chore(e2e): Test on kamelets configurations using configmaps

["squakez (via GitHub)" <gi...@apache.org>]

squakez commented on code in PR #4659:
URL: https://github.com/apache/camel-k/pull/4659#discussion_r1289613408


##########
e2e/common/config/kamelet_config_test.go:
##########
@@ -89,6 +90,25 @@ func TestKameletImplicitConfig(t *testing.T) {
 			Expect(DeleteSecret(ns, secretName)).To(Succeed())
 		})
 
+		t.Run("run test default config using mounted configmap", func(t *testing.T) {
+			name := "my-own-timer-source-default-config-mounted-configmaps"
+			cmName := "my-mounted-default-secret"
+
+			var cmData = make(map[string]string)
+			cmData["camel.kamelet.my-own-timer-source.message"] = "very top mounted configmap message"
+			Expect(CreatePlainTextConfigmap(ns, cmName, cmData)).To(Succeed())
+
+			Expect(KamelRunWithID(operatorID, ns, "files/TimerKameletIntegrationConfiguration.java",
+				"-p", "camel.kamelet.my-own-timer-source.message='Default message'",

Review Comment:
   Why passing this property? it's the same you later provide in the configmap. Unless we want to explicitly test the precedence of the trait over the property, I don't see the reason to have it specified. Do I miss something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org