You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/10/08 06:12:56 UTC
[GitHub] [kafka] showuon commented on a diff in pull request #12726: MINOR; Some sections are missing in the TOC
showuon commented on code in PR #12726:
URL: https://github.com/apache/kafka/pull/12726#discussion_r990596894
##########
docs/toc.html:
##########
@@ -111,22 +117,28 @@
<li><a href="#multitenancy-georeplication">Multi-Tenancy and Geo-Replication</a></li>
<li><a href="#multitenancy-more">Further considerations</a></li>
</ul>
+ </li>
<li><a href="#config">6.5 Important Configs</a>
<ul>
<li><a href="#clientconfig">Important Client Configs</a>
<li><a href="#prodconfig">A Production Server Configs</a>
</ul>
+ </li>
<li><a href="#java">6.6 Java Version</a>
<li><a href="#hwandos">6.7 Hardware and OS</a>
<ul>
- <li><a href="#os">OS</a>
- <li><a href="#diskandfs">Disks and Filesystems</a>
- <li><a href="#appvsosflush">Application vs OS Flush Management</a>
- <li><a href="#linuxflush">Linux Flush Behavior</a>
- <li><a href="#ext4">Ext4 Notes</a>
+ <li><a href="#os">OS</a></li>
+ <li><a href="#diskandfs">Disks and Filesystems</a></li>
+ <li><a href="#appvsosflush">Application vs OS Flush Management</a></li>
+ <li><a href="#linuxflush">Linux Flush Behavior</a></li>
+ <li><a href="#filesystems">Filesystem Selection</a></li>
+ <li><a href="#replace_disk">Replace KRaft Controller Disk</a></li>
</ul>
+ </li>
<li><a href="#monitoring">6.8 Monitoring</a>
<ul>
+ <li><a href="#remote_jmx">Security Considerations for Remote Monitoring using JMX</a></li>
+ <li><a href="#kraft_monitoring">KRaft Monitoring Metrics</a></li>
Review Comment:
I think we can remove `Metrics` for consistency with the ones below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org