You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/15 10:46:30 UTC
[kudu-CR] threadpool: use move semantics where possible
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5518
to review the following change.
Change subject: threadpool: use move semantics where possible
......................................................................
threadpool: use move semantics where possible
This uses std::move() where possible to avoid extra copies or reference
counting overhead in the ThreadPool code.
Change-Id: I180154bd7fd9ecd40188490db0b60ae8e58e554f
---
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
2 files changed, 6 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/5518/1
--
To view, visit http://gerrit.cloudera.org:8080/5518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I180154bd7fd9ecd40188490db0b60ae8e58e554f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] threadpool: use move semantics where possible
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: threadpool: use move semantics where possible
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5518/1/src/kudu/util/threadpool.cc
File src/kudu/util/threadpool.cc:
Line 241: queue_.push_back(e);
probably should be using emplace_back and a std::move here
--
To view, visit http://gerrit.cloudera.org:8080/5518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I180154bd7fd9ecd40188490db0b60ae8e58e554f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] threadpool: use move semantics where possible
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: threadpool: use move semantics where possible
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I180154bd7fd9ecd40188490db0b60ae8e58e554f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] threadpool: use move semantics where possible
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5518
to look at the new patch set (#2).
Change subject: threadpool: use move semantics where possible
......................................................................
threadpool: use move semantics where possible
This uses std::move() where possible to avoid extra copies or reference
counting overhead in the ThreadPool code.
Change-Id: I180154bd7fd9ecd40188490db0b60ae8e58e554f
---
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
2 files changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/5518/2
--
To view, visit http://gerrit.cloudera.org:8080/5518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I180154bd7fd9ecd40188490db0b60ae8e58e554f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] threadpool: use move semantics where possible
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: threadpool: use move semantics where possible
......................................................................
threadpool: use move semantics where possible
This uses std::move() where possible to avoid extra copies or reference
counting overhead in the ThreadPool code.
Change-Id: I180154bd7fd9ecd40188490db0b60ae8e58e554f
Reviewed-on: http://gerrit.cloudera.org:8080/5518
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
2 files changed, 7 insertions(+), 9 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I180154bd7fd9ecd40188490db0b60ae8e58e554f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] threadpool: use move semantics where possible
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: threadpool: use move semantics where possible
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5518
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I180154bd7fd9ecd40188490db0b60ae8e58e554f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No