You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/05/24 07:23:18 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command

sv2000 commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command
URL: https://github.com/apache/incubator-gobblin/pull/2578#discussion_r287240383
 
 

 ##########
 File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixRetriggeringJobCallable.java
 ##########
 @@ -152,7 +152,7 @@ public Void call() throws JobException {
         GobblinClusterConfigurationKeys.JOB_ALWAYS_DELETE,
         "false");
 
-    try {
+    try { //TODO: what is really the difference ?
 
 Review comment:
   Why is this relevant to this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services