You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/07/13 09:03:56 UTC
[GitHub] flink pull request #2237: [FLINK-4206][metrics] Remove alphanumeric name res...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2237
[FLINK-4206][metrics] Remove alphanumeric name restriction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 4206_me_so_special
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2237
----
commit 9f72ac66d748fe1aab1ee382c33d55ab5dc717fe
Author: zentol <ch...@apache.org>
Date: 2016-07-13T09:03:08Z
[FLINK-4206][metrics] Remove alphanumeric name restriction
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2237: [FLINK-4206][metrics] Remove alphanumeric name res...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2237: [FLINK-4206][metrics] Remove alphanumeric name restrictio...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2237
I stumbled across this and I found the limitation quite annoying, so if there are no good reasons for the check, I agree to remove it.
Since @StephanEwen wrote this, it might be good if he could confirm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2237: [FLINK-4206][metrics] Remove alphanumeric name restrictio...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2237
Okay, I see.
Then I'm going to merge the change now ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2237: [FLINK-4206][metrics] Remove alphanumeric name restrictio...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2237
Actually, I just wrote a more efficient version of a check that was there before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---