You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Anubhav Kale (JIRA)" <ji...@apache.org> on 2016/02/12 23:54:18 UTC

[jira] [Updated] (CASSANDRA-11168) Hint Metrics are updated even if hinted_hand-offs=false

     [ https://issues.apache.org/jira/browse/CASSANDRA-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anubhav Kale updated CASSANDRA-11168:
-------------------------------------
    Description: 
In our PROD logs, we noticed a lot of hint metrics even though we have disabled hinted handoffs.

The reason is StorageProxy.ShouldHint has an inverted if condition. 
We should also wrap the if (hintWindowExpired) block in if (DatabaseDescriptor.hintedHandoffEnabled()).

The fix is easy, and I can provide a patch.

  was:
In our PROD logs, we noticed a lot of hint metrics even though we have disabled hinted handoffs.

The reason is StorageProxy.ShouldHint has an inverted if condition. We should also wrap the if (hintWindowExpired) block in if (DatabaseDescriptor.hintedHandoffEnabled()) as well.

The fix is easy, and I can provide a patch.


> Hint Metrics are updated even if hinted_hand-offs=false
> -------------------------------------------------------
>
>                 Key: CASSANDRA-11168
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11168
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Anubhav Kale
>            Priority: Minor
>
> In our PROD logs, we noticed a lot of hint metrics even though we have disabled hinted handoffs.
> The reason is StorageProxy.ShouldHint has an inverted if condition. 
> We should also wrap the if (hintWindowExpired) block in if (DatabaseDescriptor.hintedHandoffEnabled()).
> The fix is easy, and I can provide a patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)