You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/25 17:15:45 UTC
[GitHub] [superset] lyndsiWilliams opened a new pull request #18164: fix: Dataset column names are no longer editable
lyndsiWilliams opened a new pull request #18164:
URL: https://github.com/apache/superset/pull/18164
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The name field in the column field of the edit dataset modal should not be editable.
Bonus: I also vertically-aligned the rows in the calculated columns tab
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
#### BEFORE
Columns tab:
<img width="875" alt="columnsBefore" src="https://user-images.githubusercontent.com/55605634/151021000-9cb156ad-a3e0-4d33-83b0-39b680387dd1.png">
Calculated columns tab:
<img width="875" alt="calculatedColumnsBefore" src="https://user-images.githubusercontent.com/55605634/151021054-50e3a0ee-ba2d-4c99-b63c-6cb29097163b.png">
#### AFTER
Columns tab:
<img width="875" alt="columnsAfter" src="https://user-images.githubusercontent.com/55605634/151021194-77bbcdf3-6aeb-4486-8f06-07c78fc27be6.png">
Calculated columns tab:
<img width="875" alt="calculatedColumnsAfter" src="https://user-images.githubusercontent.com/55605634/151021249-0576b137-52f2-4a96-a6bd-27fc184c8472.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Open the edit dataset modal and observe the changes on the Columns tab and the Calculated Columns tab
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh commented on pull request #18164: fix: Dataset column names are no longer editable
Posted by GitBox <gi...@apache.org>.
hughhhh commented on pull request #18164:
URL: https://github.com/apache/superset/pull/18164#issuecomment-1021401270
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on a change in pull request #18164: fix: Dataset column names are no longer editable
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on a change in pull request #18164:
URL: https://github.com/apache/superset/pull/18164#discussion_r791935936
##########
File path: superset-frontend/src/components/Datasource/DatasourceEditor.test.jsx
##########
@@ -78,7 +78,7 @@ describe('DatasourceEditor', () => {
});
userEvent.click(getToggles[0]);
const getTextboxes = screen.getAllByRole('textbox');
- expect(getTextboxes.length).toEqual(12);
+ expect(getTextboxes.length).toEqual(5);
Review comment:
oh what caused this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #18164: fix: Dataset column names are no longer editable
Posted by GitBox <gi...@apache.org>.
yousoph commented on pull request #18164:
URL: https://github.com/apache/superset/pull/18164#issuecomment-1021440914
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams merged pull request #18164: fix: Dataset column names are no longer editable
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams merged pull request #18164:
URL: https://github.com/apache/superset/pull/18164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #18164: fix: Dataset column names are no longer editable
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #18164:
URL: https://github.com/apache/superset/pull/18164#discussion_r792016221
##########
File path: superset-frontend/src/components/Datasource/DatasourceEditor.test.jsx
##########
@@ -78,7 +78,7 @@ describe('DatasourceEditor', () => {
});
userEvent.click(getToggles[0]);
const getTextboxes = screen.getAllByRole('textbox');
- expect(getTextboxes.length).toEqual(12);
+ expect(getTextboxes.length).toEqual(5);
Review comment:
The editable names were text boxes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18164: fix: Dataset column names are no longer editable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18164:
URL: https://github.com/apache/superset/pull/18164#issuecomment-1021402791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18164: fix: Dataset column names are no longer editable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18164:
URL: https://github.com/apache/superset/pull/18164#issuecomment-1021585618
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #18164: fix: Dataset column names are no longer editable
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #18164:
URL: https://github.com/apache/superset/pull/18164#issuecomment-1021439918
# [Codecov](https://codecov.io/gh/apache/superset/pull/18164?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18164](https://codecov.io/gh/apache/superset/pull/18164?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d178ea3) into [master](https://codecov.io/gh/apache/superset/commit/fa104fee9a20dbd2175f60c50043886b8b8f7408?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa104fe) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/18164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18164 +/- ##
=======================================
Coverage 65.95% 65.95%
=======================================
Files 1584 1584
Lines 62063 62064 +1
Branches 6273 6273
=======================================
+ Hits 40934 40935 +1
Misses 19508 19508
Partials 1621 1621
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.88% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/src/components/Datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/18164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | `69.36% <100.00%> (+0.42%)` | :arrow_up: |
| [...rc/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/superset/pull/18164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0QXJlYUNvbnRyb2wuanN4) | `80.00% <0.00%> (-4.22%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18164?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18164?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa104fe...d178ea3](https://codecov.io/gh/apache/superset/pull/18164?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #18164: fix: Dataset column names are no longer editable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18164:
URL: https://github.com/apache/superset/pull/18164#issuecomment-1021442991
@yousoph Ephemeral environment spinning up at http://34.219.63.217:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org