You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by guillaumedev <gi...@git.apache.org> on 2016/01/20 21:56:47 UTC
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
GitHub user guillaumedev opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67
Update iOS geolocation plugin to avoid THREAD WARNING: ['Geolocation'…
To avoid warning "THREAD WARNING: ['Geolocation'] took 'X' ms. Plugin should use a background thread.", i added [self.commandDelegate runInBackground:^{ }]; around the code in getLocation method. By doing so, the execution of this code takes place in a new thread and works all the same.
Apple sometimes can reject application because of that, so it can only be good to add it, as simple as it is.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guillaumedev/cordova-plugin-geolocation master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit 8fbceca845441f4f421548f243d2f05573d11225
Author: Guillaumedev <co...@guillaumedev.com>
Date: 2016-01-20T20:47:40Z
Update iOS geolocation plugin to avoid THREAD WARNING: ['Geolocation'], operation occurs in new Thread
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Posted by sputn1k <gi...@git.apache.org>.
Github user sputn1k commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-211014899
its working still thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/67
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Posted by bhandaribhumin <gi...@git.apache.org>.
Github user bhandaribhumin commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-205434835
@guillaumedev please give me full code i'm having issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Posted by rammie <gi...@git.apache.org>.
Github user rammie commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-200121717
Why is this not being merged in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Posted by kaynz <gi...@git.apache.org>.
Github user kaynz commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-210304438
This is just a mirror repository. Post it on cordova jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Posted by enniob <gi...@git.apache.org>.
Github user enniob commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-180747641
I'm having the same issue with this plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Posted by alejandromagnorsky <gi...@git.apache.org>.
Github user alejandromagnorsky commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-208175842
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Posted by guillaumedev <gi...@git.apache.org>.
Github user guillaumedev commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-203836097
I don't know, seems hard to be accepted :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Posted by guillaumedev <gi...@git.apache.org>.
Github user guillaumedev commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-205721024
Please test it with my fork https://github.com/guillaumedev/cordova-plugin-geolocation
It's been some weeks since i played with it so i don't know if it's still working, but i think so. Tell me what error you have (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Update iOS geolocation pl...
Posted by guillaumedev <gi...@git.apache.org>.
Github user guillaumedev commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/67#issuecomment-181782297
Just try my solution, and there is no problem anymore :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org