You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by chenliang613 <gi...@git.apache.org> on 2017/11/21 03:07:02 UTC
[GitHub] carbondata pull request #1540: [CARBONDATA-1784] clear column group code
GitHub user chenliang613 opened a pull request:
https://github.com/apache/carbondata/pull/1540
[CARBONDATA-1784] clear column group code
Clear column group code.
- [X] Any interfaces changed?
NA
- [X] Any backward compatibility impacted?
NA
- [X] Document update required?
NA
- [X] Testing done
NA
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenliang613/carbondata col_group
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1540
----
commit 0324cce43cde7cb753b6fe958ec01d6312acabe4
Author: chenliang613 <ch...@huawei.com>
Date: 2017-11-21T03:04:49Z
[CARBONDATA-1784] clear column group code
----
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3059/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4303/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1363/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5905/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1540
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1846/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7129/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1401/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1540
retest this please
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1540
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1814/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1361/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3981/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1322/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/957/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1540
I think there are more place has column group information, it is better to remove all of them in one PR
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5191/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1540
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1339/
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1540
@chenliang613 , it seems there are many places about column group need to be removed, for example:
in TableNewProcessor.process():
`checkColGroupsValidity(cm.columnGroups, allColumns, highCardinalityDims)`
`updateColumnGroupsInFields(cm.columnGroups, allColumns)`
Method 'checkColGroupsValidity' and 'updateColumnGroupsInFields' also can be removed.
Method 'CarbonDDLSqlParser.updateColumnGroupsInField' also can be removed.
Suggestion: in CarbonDDLSqlParserprepareTableModel, we can throw an exception when user define 'column_groups' in TBLPROPERTIES.
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1540
retest this please
---
[GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1540
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1782/
---
[GitHub] carbondata pull request #1540: [CARBONDATA-1784] clear column group code
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 closed the pull request at:
https://github.com/apache/carbondata/pull/1540
---