[GitHub] [superset] amitmiran137 commented on a diff in pull request #19753: fix(QueryContext): validation does not validate query_context metrics

[GitBox <gi...@apache.org>]

amitmiran137 commented on code in PR #19753:
URL: https://github.com/apache/superset/pull/19753#discussion_r854227070


##########
tests/integration_tests/databases/api_tests.py:
##########
@@ -1111,6 +1111,7 @@ def test_get_allow_file_upload_true_csv(self):
     def mock_empty_csv_function(d, user):
         return []
 
+    @pytest.mark.skip("the excepted count is not well defined")

Review Comment:
   I don't think it is ok to create a test dependent on side effects of other tests .
   
   If this test is that in stable we should remove until you can figure out a proper quality solution 
   
   @villebro WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org