[GitHub] [solr] gerlowskija commented on pull request #1594: SOLR-16392: Convert v2 shard, replica deletion to JAX-RS

["gerlowskija (via GitHub)" <gi...@apache.org>]

gerlowskija commented on PR #1594:
URL: https://github.com/apache/solr/pull/1594#issuecomment-1540172129

   > Maybe we don't count it as a delete anymore, when the action is more of a scale. So `PUT /api/collections/Cn/replicas/scale?count=123`
   
   Thanks for the suggestion!
   
   I have some REST-fulness quibbles: having a "replicas" path that doesn't live under `/shards/Sn` might be confusing to users who are familiar with the `/collections/Cn/shards/Sn/replicas/Rn` pattern we've established with other APIs.  But it's definitely the best option at this point IMO!
   
   Thinking aloud a bit, maybe we keep the idea of this being a "scaling" API, but drop the "replicas" path segment.  e.g `PUT /api/collections/Cn/scale`
   
   Longer term, maybe this behavior could even be folded into MODIFYCOLLECTION: when someone does a "modify" (`PUT /api/collections/Cn {...}`) which happens to change `nrtReplicas`, etc, Solr would do the scaling for them.  Though of course that'd be a larger change and not something to tackle here...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org