[GitHub] [iceberg] nastra commented on a diff in pull request #6167: Build: Add -DallVersions property that exposes all component versions

[GitBox <gi...@apache.org>]

nastra commented on code in PR #6167:
URL: https://github.com/apache/iceberg/pull/6167#discussion_r1018975215


##########
settings.gradle:
##########
@@ -52,6 +52,12 @@ project(':nessie').name = 'iceberg-nessie'
 project(':gcp').name = 'iceberg-gcp'
 project(':dell').name = 'iceberg-dell'
 
+if (null != System.getProperty("allVersions")) {
+  System.setProperty("flinkVersions", System.getProperty("knownFlinkVersions"))

Review Comment:
   If any of `flinkVersions` / `sparkVersions` / `hiveVersions` have been set in addition to `allVersions`, then I think it's probably ok to just overwrite whatever was set with all the versions, unless we'd want to support something like `./gradlew -DallVersions spotlessApply -DflinkVersions=xyz`  where `sparkVersions` / `hiveVersions` would be set to all, but `flinkVersions` to what was specified



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org