RE: cvs commit: httpd-2.0/support ab.c

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

From: trawick@apache.org [mailto:trawick@apache.org]
Sent: Monday, January 08, 2001 10:48 PM

trawick     01/01/08 20:48:18

  Modified:    support  ab.c
  Log:
  get rid of a non-portable use of errno
  
  @@ -988,7 +988,7 @@
   
       if (apr_open(&postfd, pfile, APR_READ, mode, cntxt) != APR_SUCCESS) {
           printf("Invalid postfile name (%s)\n", pfile);
  -        return errno;
  +        return ENOENT;
       }
   
       apr_getfileinfo(&finfo, postfd);
  
Don't you mean APR_ENOENT here?  
  

Re: cvs commit: httpd-2.0/support ab.c

[Jeff Trawick <tr...@bellsouth.net>]

"William A. Rowe, Jr." <wr...@rowe-clan.net> writes:

> From: trawick@apache.org [mailto:trawick@apache.org]
> Sent: Monday, January 08, 2001 10:48 PM
> 
> trawick     01/01/08 20:48:18
> 
>   Modified:    support  ab.c
>   Log:
>   get rid of a non-portable use of errno
>   
>   @@ -988,7 +988,7 @@
>    
>        if (apr_open(&postfd, pfile, APR_READ, mode, cntxt) != APR_SUCCESS) {
>            printf("Invalid postfile name (%s)\n", pfile);
>   -        return errno;
>   +        return ENOENT;
>        }
>    
>        apr_getfileinfo(&finfo, postfd);
>   
> Don't you mean APR_ENOENT here?  

Hmmm... I can mean that if you want me to :)

There are a couple of other errno values returned explicitly in this
function (have a look at function open_postfile()).  I can convert all
three to APR_Exxx.  Okay?

and there is another bug in the function (change && to ||)

-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...