[jira] [Commented] (TAJO-981) Help command (\?) in tsql takes too long time.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154506#comment-14154506 ] 

ASF GitHub Bot commented on TAJO-981:
-------------------------------------

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/174#issuecomment-57428918
  
    +1
    
    Hi @hys9958 
    Thank you for your contribution. 
    It looks good to me and it ran as expected on test cluster. :)


> Help command (\?) in tsql takes too long time.
> ----------------------------------------------
>
>                 Key: TAJO-981
>                 URL: https://issues.apache.org/jira/browse/TAJO-981
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: Hyunsik Choi
>            Assignee: YeonSu Han
>            Priority: Trivial
>             Fix For: 0.9.0
>
>
> HelpCommand class firstly retrieves the documentation in tajo.apache.org. Its approach looks good. But, it is likely to take too long time (usually 1-3 seconds) at first time. We should resolve it or remove it.
> {code}
> try {
>         URL u = new URL("http://tajo.apache.org/docs/"+ tajoVersion + "/");
>         HttpURLConnection huc =  (HttpURLConnection) u.openConnection();
>         huc.setConnectTimeout(1000);
>         huc.setReadTimeout(1000);
>         huc.setRequestMethod("HEAD");
>         if(huc.getResponseCode() == HttpURLConnection.HTTP_OK) {
>           docVersion = tajoVersion;
>         } else {
>           docVersion = docDefaultVersion;
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)