You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/11/12 21:35:48 UTC
[GitHub] jerrypeng edited a comment on issue #2969: JSONSchema fails to
serialise fields on objects that are nested in a collection
jerrypeng edited a comment on issue #2969: JSONSchema fails to serialise fields on objects that are nested in a collection
URL: https://github.com/apache/pulsar/pull/2969#issuecomment-438036483
@chrismiller thanks for reporting this.
I have removed the code in the JSONSchema that was causing the problem. The original reason we added that code was so that fields from child classes don't get serialized if the schema is set to the base class. However, after some thinking, I don't think this is necessary and likely impossible to accomplish given the problem @chrismiller described. I think its ok to still serialize the field of child classes and write them to a topic given that you can read them out on the consumer end as the base class which currently you can. So I don't see a point to going down the rabbit hole of how not to serialize child class fields. We might even want this behavior given that users can evolve their schema over time.
@sijie @srkukarni @merlimat @ivankelly what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services