You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2025/01/15 08:25:59 UTC

[Impala-ASF-CR] IMPALA-13205: Do not include Iceberg position fields for MERGE statements with INSERT merge clauses

Peter Rozsa has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21931 )

Change subject: IMPALA-13205: Do not include Iceberg position fields for MERGE statements with INSERT merge clauses
......................................................................

IMPALA-13205: Do not include Iceberg position fields for MERGE
statements with INSERT merge clauses

This patch makes the Iceberg position field inclusion conditional by
including them only if there are UPDATE or DELETE merge clauses that are
listed in a MERGE statement.

Tests:
 - iceberg-merge-insert-only planner test added

Change-Id: Ib62c78dab557625fa86988559b3732591755106f
---
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge-insert-only.test
3 files changed, 245 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/21931/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib62c78dab557625fa86988559b3732591755106f
Gerrit-Change-Number: 21931
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>