You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "nsivabalan (via GitHub)" <gi...@apache.org> on 2023/03/23 06:39:44 UTC

[GitHub] [hudi] nsivabalan commented on a diff in pull request #8275: [HUDI-5289] Avoiding repeated trigger of clustering dag

nsivabalan commented on code in PR #8275:
URL: https://github.com/apache/hudi/pull/8275#discussion_r1145743054


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala:
##########
@@ -1410,6 +1411,47 @@ class TestCOWDataSource extends HoodieSparkClientTestBase with ScalaAssertionSup
     assertEquals(false, Metrics.isInitialized(basePath), "Metrics should be shutdown")
   }
 
+  /**
+   * Validates that clustering dag is triggered only once.
+   * We leverage spark event listener to validate it.
+   */
+  @Test
+  def testValidateClusteringForRepeatedDag(): Unit = {

Review Comment:
   Note to Reviewer: this test fails w/o the fix in this patch. w/ the fix, it succeeds. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org