You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/01/15 02:56:26 UTC

Review Request 29910: Configure Identities page tweaks

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29910/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-9137
    https://issues.apache.org/jira/browse/AMBARI-9137


Repository: ambari


Description
-------

Two tabs: "General" and "Advanced"

**General**
"Ambari Principals" section: hdfs, hbase, smoke principal/keytab, etc

**Advanced**
Global section: REALM (read-only), keytab dir (editable)
Section for each service (e.g, HDFS, HBase, YARN,...)

Mirror the changes in Add Services Wizard > Configure Identities page and under Admin > Security page.


Diffs
-----

  ambari-web/app/controllers/main/admin/kerberos.js be5b23f 
  ambari-web/app/controllers/main/admin/kerberos/step4_controller.js 8ac005c 
  ambari-web/app/data/HDP2/site_properties.js 6ab8adb 
  ambari-web/app/messages.js 5fe6c4f 
  ambari-web/app/mixins/wizard/addSecurityConfigs.js ee14a49 
  ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 361175b 

Diff: https://reviews.apache.org/r/29910/diff/


Testing
-------

tested e2e.
**ambari-web unit test result with patch:**

  5191 tests complete (8 seconds)
  61 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 29910: Configure Identities page tweaks

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29910/#review68186
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Jan. 15, 2015, 1:56 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29910/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 1:56 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9137
>     https://issues.apache.org/jira/browse/AMBARI-9137
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Two tabs: "General" and "Advanced"
> 
> **General**
> "Ambari Principals" section: hdfs, hbase, smoke principal/keytab, etc
> 
> **Advanced**
> Global section: REALM (read-only), keytab dir (editable)
> Section for each service (e.g, HDFS, HBase, YARN,...)
> 
> Mirror the changes in Add Services Wizard > Configure Identities page and under Admin > Security page.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/kerberos.js be5b23f 
>   ambari-web/app/controllers/main/admin/kerberos/step4_controller.js 8ac005c 
>   ambari-web/app/data/HDP2/site_properties.js 6ab8adb 
>   ambari-web/app/messages.js 5fe6c4f 
>   ambari-web/app/mixins/wizard/addSecurityConfigs.js ee14a49 
>   ambari-web/test/controllers/main/admin/kerberos/step4_controller_test.js 361175b 
> 
> Diff: https://reviews.apache.org/r/29910/diff/
> 
> 
> Testing
> -------
> 
> tested e2e.
> **ambari-web unit test result with patch:**
> 
>   5191 tests complete (8 seconds)
>   61 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>