[GitHub] [incubator-doris] Gabriel39 commented on a change in pull request #6966: [Feature]Support decimal for es scan

[GitBox <gi...@apache.org>]

Gabriel39 commented on a change in pull request #6966:
URL: https://github.com/apache/incubator-doris/pull/6966#discussion_r745258233



##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -416,6 +416,33 @@ Status ScrollParser::fill_tuple(const TupleDescriptor* tuple_desc, Tuple* tuple,
             break;
         }
 
+        case TYPE_DECIMALV2: {

Review comment:
       OK. Make sense for me. Btw, I think we should give users some tips in DOC or throw Exception here In case of unexpected errors when using decimal for es scan




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org