You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/06/26 08:33:58 UTC

[GitHub] [dubbo-go] EnableAsync commented on a change in pull request #1278: Ftr: Adding integration tests using dubbo-go-samples

EnableAsync commented on a change in pull request #1278:
URL: https://github.com/apache/dubbo-go/pull/1278#discussion_r659139931



##########
File path: .github/workflows/github-actions.yml
##########
@@ -69,9 +69,17 @@ jobs:
       run: |
         make verify
 
+      # This step only runs when the event type is a pull_request
     - name: Integrate Test
+      if: ${{ github.event_name == 'pull_request' }}
       run: |
-        chmod +x integrate_test.sh && ./integrate_test.sh ${{github.event.pull_request.head.repo.full_name}} ${{github.event.pull_request.head.sha}}
+        chmod +x integrate_test.sh && [[ -n "${{github.event.pull_request.head.repo.full_name}}" ]] && [[ -n "${{github.event.pull_request.head.sha}}" ]] && [[ -n "${{github.base_ref}}" ]] && ./integrate_test.sh ${{github.event.pull_request.head.repo.full_name}} ${{github.event.pull_request.head.sha}} ${{github.base_ref}}
+
+      # This step only runs when the event type is a push
+    - name: Integrate Test

Review comment:
       Does it mean to distinguish pull_request from push?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org