You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Tangruilin (via GitHub)" <gi...@apache.org> on 2025/09/20 11:54:15 UTC
[I] cmake hang [iceberg-cpp]
Tangruilin opened a new issue, #240:
URL: https://github.com/apache/iceberg-cpp/issues/240
<img width="2420" height="1644" alt="Image" src="https://github.com/user-attachments/assets/394cfc33-900d-4d95-bcbc-9f4a5fd2a965" />
command `cmake -S . -B build -G Ninja -DCMAKE_INSTALL_PREFIX=./install -DICEBERG_BUILD_STATIC=ON -DICEBERG_BUILD_SHARED=O -DENABLE_ROARING_MICROBENCHMARKS=ON -DHAVE_PTHREAD_AFFINITY=OFF` may hang
my envirment is Mac m2 pro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "zhjwpku (via GitHub)" <gi...@apache.org>.
zhjwpku closed issue #240: cmake hang
URL: https://github.com/apache/iceberg-cpp/issues/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "Tangruilin (via GitHub)" <gi...@apache.org>.
Tangruilin commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315885308
> > > > > It seems pointless to run these tests and benchmarks within iceberg-cpp. I disable them in [#241](https://github.com/apache/iceberg-cpp/pull/241), can you give it a try?
> > > >
> > > >
> > > > cpu_set_t is not support on MacOS, it is only supported on Linux. Then I found the flag `HAVE_PTHREAD_AFFINITY=off` is not useful, you can manually comment out the CPU affinity settings to solve this problem. like below:
> > > > # pthread affinity, if available
> > > > if(HAVE_PTHREAD_AFFINITY)
> > > > #target_compile_definitions(benchmark PRIVATE -DBENCHMARK_HAS_PTHREAD_AFFINITY)
> > > > endif()
> > >
> > >
> > > I digged into this a little bit, when you set HAVE_PTHREAD_AFFINITY either to on or off, google benchmark will define HAVE_PTHREAD_AFFINITY, see [1]. Then I tried `cmake -S . -B build -DENABLE_ROARING_MICROBENCHMARKS=ON` to build CRoaring, it passed. You can observe some message like:
> > > ```
> > > -- Compiling and running to test HAVE_PTHREAD_AFFINITY
> > > -- Performing Test HAVE_PTHREAD_AFFINITY -- failed to compile
> > > ```
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > I think HAVE_PTHREAD_AFFINITY is supposed to be automatically detected and set by the google benchmark building system, may I ask why you specify it manually?
> > > [1] https://github.com/google/benchmark/blob/main/cmake/CXXFeatureCheck.cmake#L26-L29
> >
> >
> > ..., MacOS do not have `cpu_set_t `, so benchmark's PTHREAD_AFFINITY can not open on Mac
>
> After checking your reply again, I confirm that the error triggered by `-DCXXFEATURECHECK_DEBUG=on` is not an actual issue, it's intentionally used by the build system to probe OS capabilities during feature detection, I'll close this issue if no further comments.
I think this is a Google Benchmark's bug where CPU affinity is enabled, and it doesn't seem to be compatible with macOS. However, since Iceberg depends on Google Benchmark, it should at least inform macOS developers how to handle this error, rather than casually assuming that CPU affinity detection is expected behavior and therefore not treating it as a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "Tangruilin (via GitHub)" <gi...@apache.org>.
Tangruilin commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315889872
> > > > > > It seems pointless to run these tests and benchmarks within iceberg-cpp. I disable them in [#241](https://github.com/apache/iceberg-cpp/pull/241), can you give it a try?
> > > > >
> > > > >
> > > > > cpu_set_t is not support on MacOS, it is only supported on Linux. Then I found the flag `HAVE_PTHREAD_AFFINITY=off` is not useful, you can manually comment out the CPU affinity settings to solve this problem. like below:
> > > > > # pthread affinity, if available
> > > > > if(HAVE_PTHREAD_AFFINITY)
> > > > > #target_compile_definitions(benchmark PRIVATE -DBENCHMARK_HAS_PTHREAD_AFFINITY)
> > > > > endif()
> > > >
> > > >
> > > > I digged into this a little bit, when you set HAVE_PTHREAD_AFFINITY either to on or off, google benchmark will define HAVE_PTHREAD_AFFINITY, see [1]. Then I tried `cmake -S . -B build -DENABLE_ROARING_MICROBENCHMARKS=ON` to build CRoaring, it passed. You can observe some message like:
> > > > ```
> > > > -- Compiling and running to test HAVE_PTHREAD_AFFINITY
> > > > -- Performing Test HAVE_PTHREAD_AFFINITY -- failed to compile
> > > > ```
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > I think HAVE_PTHREAD_AFFINITY is supposed to be automatically detected and set by the google benchmark building system, may I ask why you specify it manually?
> > > > [1] https://github.com/google/benchmark/blob/main/cmake/CXXFeatureCheck.cmake#L26-L29
> > >
> > >
> > > ..., MacOS do not have `cpu_set_t `, so benchmark's PTHREAD_AFFINITY can not open on Mac
> >
> >
> > After checking your reply again, I confirm that the error triggered by `-DCXXFEATURECHECK_DEBUG=on` is not an actual issue, it's intentionally used by the build system to probe OS capabilities during feature detection, I'll close this issue if no further comments.
>
> I think this is a Google Benchmark's bug where CPU affinity is enabled, and it doesn't seem to be compatible with macOS. However, since Iceberg depends on Google Benchmark, it should at least inform macOS developers how to handle this error, rather than casually assuming that CPU affinity detection is expected behavior and therefore not treating it as a bug
it seems https://github.com/apache/iceberg-cpp/pull/241 can slove this, if set `-DENABLE_ROARING_MICROBENCHMARKS=OFF` this can be ok. ths!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "Tangruilin (via GitHub)" <gi...@apache.org>.
Tangruilin commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315058505
> > You might need to set up http(s) proxy. It may hang when trying to download vendored dependencies.
>
> <img alt="Image" width="2000" height="614" src="https://private-user-images.githubusercontent.com/23651891/491947083-690dc3b4-301b-4522-ab66-851d9d36545c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTgzODI4NTUsIm5iZiI6MTc1ODM4MjU1NSwicGF0aCI6Ii8yMzY1MTg5MS80OTE5NDcwODMtNjkwZGMzYjQtMzAxYi00NTIyLWFiNjYtODUxZDlkMzY1NDVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA5MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwOTIwVDE1MzU1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3OWQ1MTExMjhhMjA5MjZhNDNkMDFkYjcxMWY1YTlmZjhlYzhjODNlNjFmYTllNWMxOWUzYzdiZDgzM2VjNzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.QVrXaFC2mfvBzJcQDzjgKEfwK9Gohv--H_98YCcoKmE">
> the `google-benchmark` version that iceberg-cpp dependecy not support PTHREAD_AFFINITY, maybe it need to be marked in `README.txt`
>
> Additionally, I'd like to ask if there are plans for Iceberg to support development on Mac.
use flag `-DCXXFEATURECHECK_DEBUG=on` can look the error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "zhjwpku (via GitHub)" <gi...@apache.org>.
zhjwpku commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315870933
> > > > It seems pointless to run these tests and benchmarks within iceberg-cpp. I disable them in [#241](https://github.com/apache/iceberg-cpp/pull/241), can you give it a try?
> > >
> > >
> > > cpu_set_t is not support on MacOS, it is only supported on Linux. Then I found the flag `HAVE_PTHREAD_AFFINITY=off` is not useful, you can manually comment out the CPU affinity settings to solve this problem. like below:
> > > # pthread affinity, if available
> > > if(HAVE_PTHREAD_AFFINITY)
> > > #target_compile_definitions(benchmark PRIVATE -DBENCHMARK_HAS_PTHREAD_AFFINITY)
> > > endif()
> >
> >
> > I digged into this a little bit, when you set HAVE_PTHREAD_AFFINITY either to on or off, google benchmark will define HAVE_PTHREAD_AFFINITY, see [1]. Then I tried `cmake -S . -B build -DENABLE_ROARING_MICROBENCHMARKS=ON` to build CRoaring, it passed. You can observe some message like:
> > ```
> > -- Compiling and running to test HAVE_PTHREAD_AFFINITY
> > -- Performing Test HAVE_PTHREAD_AFFINITY -- failed to compile
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > I think HAVE_PTHREAD_AFFINITY is supposed to be automatically detected and set by the google benchmark building system, may I ask why you specify it manually?
> > [1] https://github.com/google/benchmark/blob/main/cmake/CXXFeatureCheck.cmake#L26-L29
>
> ..., MacOS do not have `cpu_set_t `, so benchmark's PTHREAD_AFFINITY can not open on Mac
After checking your reply again, I confirm that the error triggered by `-DCXXFEATURECHECK_DEBUG=on` is not an actual issue, it's intentionally used by the build system to probe OS capabilities during feature detection, I'll close this issue if no further comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "Tangruilin (via GitHub)" <gi...@apache.org>.
Tangruilin commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315058120
> You might need to set up http(s) proxy. It may hang when trying to download vendored dependencies.
<img width="2558" height="614" alt="Image" src="https://github.com/user-attachments/assets/690dc3b4-301b-4522-ab66-851d9d36545c" />
the `google-benchmark` version that iceberg-cpp dependecy not support PTHREAD_AFFINITY, maybe it need to be marked in `README.txt`
Additionally, I'd like to ask if there are plans for Iceberg to support development on Mac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "zhjwpku (via GitHub)" <gi...@apache.org>.
zhjwpku commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315576786
> > It seems pointless to run these tests and benchmarks within iceberg-cpp. I disable them in [#241](https://github.com/apache/iceberg-cpp/pull/241), can you give it a try?
>
> cpu_set_t is not support on MacOS, it is only supported on Linux. Then I found the flag `HAVE_PTHREAD_AFFINITY=off` is not useful, you can manually comment out the CPU affinity settings to solve this problem. like below:
>
> # pthread affinity, if available
> if(HAVE_PTHREAD_AFFINITY)
> #target_compile_definitions(benchmark PRIVATE -DBENCHMARK_HAS_PTHREAD_AFFINITY)
> endif()
I digged into this a little bit, when you set HAVE_PTHREAD_AFFINITY either to on or off, google benchmark will define HAVE_PTHREAD_AFFINITY, see [1]. Then I tried `cmake -S . -B build -DENABLE_ROARING_MICROBENCHMARKS=ON` to build CRoaring, it passed. You can observe some message like:
```
-- Compiling and running to test HAVE_PTHREAD_AFFINITY
-- Performing Test HAVE_PTHREAD_AFFINITY -- failed to compile
```
I think HAVE_PTHREAD_AFFINITY is supposed to be automatically detected and set by the google benchmark building system, may I ask why you specify it manually?
[1] https://github.com/google/benchmark/blob/main/cmake/CXXFeatureCheck.cmake#L26-L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3314995705
You might need to set up http(s) proxy. It may hang when trying to download vendored dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "zhjwpku (via GitHub)" <gi...@apache.org>.
zhjwpku commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315499428
I download CRoaring and build with the following commands:
```
cmake -S . -B build -DENABLE_ROARING_MICROBENCHMARKS=ON -DHAVE_PTHREAD_AFFINITY=OFF
cmake --build build
```
I got the same error:
```
/Users/zjw/zjw/CRoaring/build/_deps/benchmark-src/src/sysinfo.cc:618:3: error: unknown type name 'cpu_set_t'
618 | cpu_set_t previous_affinity;
| ^
/Users/zjw/zjw/CRoaring/build/_deps/benchmark-src/src/sysinfo.cc:589:5: error: unknown type name 'cpu_set_t'
589 | cpu_set_t affinity;
| ^
/Users/zjw/zjw/CRoaring/build/_deps/benchmark-src/src/sysinfo.cc:594:25: error: use of undeclared identifier 'CPU_SETSIZE'
594 | for (int i = 0; i < CPU_SETSIZE; ++i)
| ^
/Users/zjw/zjw/CRoaring/build/_deps/benchmark-src/src/sysinfo.cc:618:13: warning: private field 'previous_affinity' is not used [-Wunused-private-field]
618 | cpu_set_t previous_affinity;
| ^
```
It seems no point to run these tests and benchmarks with iceberg-cpp. I disable them in #241, can you give it a try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "Tangruilin (via GitHub)" <gi...@apache.org>.
Tangruilin commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315647834
> > > It seems pointless to run these tests and benchmarks within iceberg-cpp. I disable them in [#241](https://github.com/apache/iceberg-cpp/pull/241), can you give it a try?
> >
> >
> > cpu_set_t is not support on MacOS, it is only supported on Linux. Then I found the flag `HAVE_PTHREAD_AFFINITY=off` is not useful, you can manually comment out the CPU affinity settings to solve this problem. like below:
> > # pthread affinity, if available
> > if(HAVE_PTHREAD_AFFINITY)
> > #target_compile_definitions(benchmark PRIVATE -DBENCHMARK_HAS_PTHREAD_AFFINITY)
> > endif()
>
> I digged into this a little bit, when you set HAVE_PTHREAD_AFFINITY either to on or off, google benchmark will define HAVE_PTHREAD_AFFINITY, see [1]. Then I tried `cmake -S . -B build -DENABLE_ROARING_MICROBENCHMARKS=ON` to build CRoaring, it passed. You can observe some message like:
>
> ```
> -- Compiling and running to test HAVE_PTHREAD_AFFINITY
> -- Performing Test HAVE_PTHREAD_AFFINITY -- failed to compile
> ```
>
> I think HAVE_PTHREAD_AFFINITY is supposed to be automatically detected and set by the google benchmark building system, may I ask why you specify it manually?
>
> [1] https://github.com/google/benchmark/blob/main/cmake/CXXFeatureCheck.cmake#L26-L29
..., MacOS do not have `cpu_set_t `, so benchmark's PTHREAD_AFFINITY can not open on Mac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "zhjwpku (via GitHub)" <gi...@apache.org>.
zhjwpku commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315891848
> > > > > > It seems pointless to run these tests and benchmarks within iceberg-cpp. I disable them in [#241](https://github.com/apache/iceberg-cpp/pull/241), can you give it a try?
> > > > >
> > > > >
> > > > > cpu_set_t is not support on MacOS, it is only supported on Linux. Then I found the flag `HAVE_PTHREAD_AFFINITY=off` is not useful, you can manually comment out the CPU affinity settings to solve this problem. like below:
> > > > > # pthread affinity, if available
> > > > > if(HAVE_PTHREAD_AFFINITY)
> > > > > #target_compile_definitions(benchmark PRIVATE -DBENCHMARK_HAS_PTHREAD_AFFINITY)
> > > > > endif()
> > > >
> > > >
> > > > I digged into this a little bit, when you set HAVE_PTHREAD_AFFINITY either to on or off, google benchmark will define HAVE_PTHREAD_AFFINITY, see [1]. Then I tried `cmake -S . -B build -DENABLE_ROARING_MICROBENCHMARKS=ON` to build CRoaring, it passed. You can observe some message like:
> > > > ```
> > > > -- Compiling and running to test HAVE_PTHREAD_AFFINITY
> > > > -- Performing Test HAVE_PTHREAD_AFFINITY -- failed to compile
> > > > ```
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > I think HAVE_PTHREAD_AFFINITY is supposed to be automatically detected and set by the google benchmark building system, may I ask why you specify it manually?
> > > > [1] https://github.com/google/benchmark/blob/main/cmake/CXXFeatureCheck.cmake#L26-L29
> > >
> > >
> > > ..., MacOS do not have `cpu_set_t `, so benchmark's PTHREAD_AFFINITY can not open on Mac
> >
> >
> > After checking your reply again, I confirm that the error triggered by `-DCXXFEATURECHECK_DEBUG=on` is not an actual issue, it's intentionally used by the build system to probe OS capabilities during feature detection, I'll close this issue if no further comments.
>
> I think this is a Google Benchmark's bug where CPU affinity is enabled, and it doesn't seem to be compatible with macOS. However, since Iceberg depends on Google Benchmark, it should at least inform macOS developers how to handle this error, rather than casually assuming that CPU affinity detection is expected behavior and therefore not treating it as a bug
Iceberg-cpp doesn't directly depend on Google Benchmark, we have CRoaring as a third party, and ENABLE_ROARING_MICROBENCHMARKS is an option from CRoaring, and I have created a PR to disable that. I also don't think this is a Google Benchmark's bug, as I already stated, the error triggered by `-DCXXFEATURECHECK_DEBUG=on` is just a check, from which Benchmark can know the os capabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "Tangruilin (via GitHub)" <gi...@apache.org>.
Tangruilin commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315538198
> I download CRoaring and build with the following commands:
>
> ```
> cmake -S . -B build -DENABLE_ROARING_MICROBENCHMARKS=ON -DHAVE_PTHREAD_AFFINITY=OFF
> cmake --build build
> ```
>
> I got the same error:
>
> ```
> /Users/zjw/zjw/CRoaring/build/_deps/benchmark-src/src/sysinfo.cc:618:3: error: unknown type name 'cpu_set_t'
> 618 | cpu_set_t previous_affinity;
> | ^
> /Users/zjw/zjw/CRoaring/build/_deps/benchmark-src/src/sysinfo.cc:589:5: error: unknown type name 'cpu_set_t'
> 589 | cpu_set_t affinity;
> | ^
> /Users/zjw/zjw/CRoaring/build/_deps/benchmark-src/src/sysinfo.cc:594:25: error: use of undeclared identifier 'CPU_SETSIZE'
> 594 | for (int i = 0; i < CPU_SETSIZE; ++i)
> | ^
> /Users/zjw/zjw/CRoaring/build/_deps/benchmark-src/src/sysinfo.cc:618:13: warning: private field 'previous_affinity' is not used [-Wunused-private-field]
> 618 | cpu_set_t previous_affinity;
> | ^
> ```
>
> It seems pointless to run these tests and benchmarks within iceberg-cpp. I disable them in [#241](https://github.com/apache/iceberg-cpp/pull/241), can you give it a try?
cpu_set_t is not support on MacOS, it is only supported on Linux.
Then I found the flag `HAVE_PTHREAD_AFFINITY=off` is not useful, you can manually comment out the CPU affinity settings to solve this problem.
like below:
```Cmake
# pthread affinity, if available
if(HAVE_PTHREAD_AFFINITY)
#target_compile_definitions(benchmark PRIVATE -DBENCHMARK_HAS_PTHREAD_AFFINITY)
endif()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "zhjwpku (via GitHub)" <gi...@apache.org>.
zhjwpku commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3315442912
> > You might need to set up http(s) proxy. It may hang when trying to download vendored dependencies.
>
> <img alt="Image" width="2000" height="614" src="https://private-user-images.githubusercontent.com/23651891/491947083-690dc3b4-301b-4522-ab66-851d9d36545c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTg0MjExODgsIm5iZiI6MTc1ODQyMDg4OCwicGF0aCI6Ii8yMzY1MTg5MS80OTE5NDcwODMtNjkwZGMzYjQtMzAxYi00NTIyLWFiNjYtODUxZDlkMzY1NDVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA5MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwOTIxVDAyMTQ0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI5OWUxNjgxOWE4YWQ3NWZmZGFmMWEyYjE1NmY1MTQ0MGIwYWQ0OTQ4NDYzN2EzN2NmNTQ4ZmZhNzBmY2QyNjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.JtfOkNFW4HzxDcJxpNbn1045YzHQwUllwxHhXdJmKQs">
> the `google-benchmark` version that iceberg-cpp dependecy not support PTHREAD_AFFINITY, maybe it need to be marked in `README.txt`
>
> Additionally, I'd like to ask if there are plans for Iceberg to support development on Mac.
I think most of the contributors use Mac to develop iceberg-cpp. Could you provide a bit more detail about the issue you're encountering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] cmake hang [iceberg-cpp]
Posted by "zhjwpku (via GitHub)" <gi...@apache.org>.
zhjwpku commented on issue #240:
URL: https://github.com/apache/iceberg-cpp/issues/240#issuecomment-3316576916
Closed as #241 merged, thanks for the report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org