You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2021/04/09 21:32:00 UTC
[jira] [Updated] (CALCITE-4575) Remove Gradle wrapper from source
distribution
[ https://issues.apache.org/jira/browse/CALCITE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Hyde updated CALCITE-4575:
---------------------------------
Description:
Apache release policy does not allow binary files in source releases, and in particular not JAR files. Calcite and Avatica source code includes the Gradle wrapper, which requires {{gradle/wrapper/gradle-wrapper.jar}}. The policy [exempts a few build tools, but the Gradle wrapper is not among them|https://lists.apache.org/thread.html/rd1aabe5052b5bedf3eceebd331f878b92a8ade6d4ca170f845d5db37%40%3Clegal-discuss.apache.org%3E]. A request to expand the list (see LEGAL-288) was denied.
In my opinion, the list should be expanded to include {{gradle-wrapper.jar}}, but that is not current policy.
I propose to solve this by removing the Gradle wrapper from the source distribution and amending {{site/_docs/howto.md}} to explain that people building from a source distribution (not from Git) need to install a particular version of Gradle first. The list of files to be removed from the source distribution is as follows:
* {{gradlew}}
* {{gradlew.bat}}
* {{gradle/wrapper/gradle-wrapper.jar}}
* {{gradle/wrapper/gradle-wrapper.properties}}
These files would not be removed from Git.
In future, anyone upgrading Gradle would also need to edit the version in {{site/_docs/howto.md}}.
(Note that OFBIZ-10145 is another solution to this problem. In my opinion, it is an inferior solution for our case. It is more complicated for people building from Git, and would require us to maintain the shell scripts that replace the functionality of {{gradle-wrapper.jar}}.)
This change needs to be applied to both Calcite and Avatica.
was:
Apache release policy does not allow binary files in source releases, and in particular not JAR files. Calcite and Avatica source code includes the Gradle wrapper, which requires {{gradle/wrapper/gradle-wrapper.jar}}. The policy [exempts a few build tools, but the Gradle wrapper is not among them||https://lists.apache.org/thread.html/rd1aabe5052b5bedf3eceebd331f878b92a8ade6d4ca170f845d5db37%40%3Clegal-discuss.apache.org%3E]. A request to expand the list (see LEGAL-288) was denied.
In my opinion, the list should be expanded to include {{gradle-wrapper.jar}}, but that is not current policy.
I propose to solve this by removing the Gradle wrapper from the source distribution and amending {{site/_docs/howto.md}} to explain that people building from a source distribution (not from Git) need to install a particular version of Gradle first. The list of files to be removed from the source distribution is as follows:
* {{gradlew}}
* {{gradlew.bat}}
* {{gradle/wrapper/gradle-wrapper.jar}}
* {{gradle/wrapper/gradle-wrapper.properties}}
These files would not be removed from Git.
In future, anyone upgrading Gradle would also need to edit the version in {{site/_docs/howto.md}}.
(Note that OFBIZ-10145 is another solution to this problem. In my opinion, it is an inferior solution for our case. It is more complicated for people building from Git, and would require us to maintain the shell scripts that replace the functionality of {{gradle-wrapper.jar}}.)
This change needs to be applied to both Calcite and Avatica.
> Remove Gradle wrapper from source distribution
> ----------------------------------------------
>
> Key: CALCITE-4575
> URL: https://issues.apache.org/jira/browse/CALCITE-4575
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Priority: Major
>
> Apache release policy does not allow binary files in source releases, and in particular not JAR files. Calcite and Avatica source code includes the Gradle wrapper, which requires {{gradle/wrapper/gradle-wrapper.jar}}. The policy [exempts a few build tools, but the Gradle wrapper is not among them|https://lists.apache.org/thread.html/rd1aabe5052b5bedf3eceebd331f878b92a8ade6d4ca170f845d5db37%40%3Clegal-discuss.apache.org%3E]. A request to expand the list (see LEGAL-288) was denied.
> In my opinion, the list should be expanded to include {{gradle-wrapper.jar}}, but that is not current policy.
> I propose to solve this by removing the Gradle wrapper from the source distribution and amending {{site/_docs/howto.md}} to explain that people building from a source distribution (not from Git) need to install a particular version of Gradle first. The list of files to be removed from the source distribution is as follows:
> * {{gradlew}}
> * {{gradlew.bat}}
> * {{gradle/wrapper/gradle-wrapper.jar}}
> * {{gradle/wrapper/gradle-wrapper.properties}}
> These files would not be removed from Git.
> In future, anyone upgrading Gradle would also need to edit the version in {{site/_docs/howto.md}}.
> (Note that OFBIZ-10145 is another solution to this problem. In my opinion, it is an inferior solution for our case. It is more complicated for people building from Git, and would require us to maintain the shell scripts that replace the functionality of {{gradle-wrapper.jar}}.)
> This change needs to be applied to both Calcite and Avatica.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)