[jira] [Resolved] (ZOOKEEPER-4232) InvalidSnapshotTest corrupts its own test data

["Mohammad Arshad (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohammad Arshad resolved ZOOKEEPER-4232.
----------------------------------------
    Fix Version/s: 3.8.0
                   3.7.0
                   3.6.3
                   3.5.10
       Resolution: Fixed

> InvalidSnapshotTest corrupts its own test data
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-4232
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4232
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Damien Diederen
>            Assignee: Damien Diederen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.10, 3.6.3, 3.7.0, 3.8.0
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> {{InvalidSnapshotTest.testSnapshot}} starts an instance of {{ZooKeeperServer}} on the version-controlled {{invalidsnap}} directory, which, as a side-effect, "fixes" the following snapshot—which is broken on purpose (see ZOOKEEPER-367):
> {{zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f}}
> This status quo creates a number of problems:
>  # It makes the test ineffective after the first run;
>  # The file shows as modified in version control tools, which can be annoying;
>  # The "fixed" snapshot can end up being committed by mistake, invalidating the test.
> (#3 is not theoretical; that "fixed" snapshot frequently shows up in pull requests, and was recently merged into master.).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)