[jira] [Commented] (AIRFLOW-5898) alembic command crashes due to typing import path collision

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971911#comment-16971911 ] 

ASF GitHub Bot commented on AIRFLOW-5898:
-----------------------------------------

houqp commented on pull request #6547: [AIRFLOW-5898] fix alembic crash due to typing import
URL: https://github.com/apache/airflow/pull/6547
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Running alemibc within airflow directory results in the following crash:
   
   ```
     File "/Users/qph/Envs/airflow/lib/python3.7/site-packages/typing_extensions.py", line 17, in <module>
       from typing import Generic, Callable, TypeVar, Tuple
   ImportError: cannot import name 'Generic' from 'typing'
   ```
   
   This is due to typing.py within airlfow directory collides with the builtin typing module when a command runs inside airflow directory. Renaming it to `custom_typing.py` fixes the issue.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   This should have been covered by mypy check.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> alembic command crashes due to typing import path collision
> -----------------------------------------------------------
>
>                 Key: AIRFLOW-5898
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5898
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: database
>    Affects Versions: 2.0.0
>            Reporter: QP Hou
>            Assignee: QP Hou
>            Priority: Trivial
>
> Running alemibc within airflow directory results in the following crash:
>  
> {code:java}
>   File "/Users/qph/Envs/airflow/lib/python3.7/site-packages/typing_extensions.py", line 17, in <module>
>     from typing import Generic, Callable, TypeVar, Tuple
> ImportError: cannot import name 'Generic' from 'typing'
> {code}
> This is due to typing.py within airlfow directory collides with the builtin typing module when a command runs inside airflow directory. Renaming it to `custom_typing.py` fixes the issue.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)