You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/22 11:08:43 UTC

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6571: [WIP] VM Autoscaling with virtual router

DaanHoogland commented on code in PR #6571:
URL: https://github.com/apache/cloudstack/pull/6571#discussion_r951308084


##########
api/src/main/java/com/cloud/network/as/AutoScalePolicy.java:
##########
@@ -38,7 +36,7 @@ public static Action fromValue(String action) {
             } else if (action.equalsIgnoreCase("ScaleDown")) {
                 return ScaleDown;
             } else {
-                throw new InvalidParameterValueException("Unexpected AutoScale action : " + action);

Review Comment:
   why must this be IllegalArgumentException @weizhouapache  (why this change?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org